Skip to content

Commit 3f22e26

Browse files
shangxinliwgtmac
authored andcommitted
fix: Address PR review comments for EqualityDeleteWriter
- Add TODO comment for encryption key_metadata field - Populate partition_spec_id from spec in DataFile metadata - Add test assertion for partition_spec_id
1 parent 6f3eaf3 commit 3f22e26

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/iceberg/data/equality_delete_writer.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
#include "iceberg/file_writer.h"
2525
#include "iceberg/manifest/manifest_entry.h"
26+
#include "iceberg/partition_spec.h"
2627
#include "iceberg/util/macros.h"
2728

2829
namespace iceberg {
@@ -101,6 +102,8 @@ class EqualityDeleteWriter::Impl {
101102
.split_offsets = std::move(split_offsets),
102103
.equality_ids = options_.equality_field_ids,
103104
.sort_order_id = options_.sort_order_id,
105+
.partition_spec_id =
106+
options_.spec ? std::make_optional(options_.spec->spec_id()) : std::nullopt,
104107
});
105108

106109
FileWriter::WriteResult result;

src/iceberg/data/equality_delete_writer.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ struct ICEBERG_EXPORT EqualityDeleteWriterOptions {
5050
std::vector<int32_t> equality_field_ids;
5151
std::optional<int32_t> sort_order_id;
5252
std::unordered_map<std::string, std::string> properties;
53+
// TODO: add key_metadata for encryption
5354
};
5455

5556
/// \brief Writer for Iceberg equality delete files.

0 commit comments

Comments
 (0)