test(rest): harden session test (ctype UB, fd race, path assertions)

Author: plusplusjiajia

src/iceberg/test/rest_catalog_session_test.cc

@@ -82,7 +82,7 @@ class MiniRestServer {
     ::getsockname(listen_fd_, reinterpret_cast<sockaddr*>(&addr), &len);
     port_ = ntohs(addr.sin_port);
     if (::listen(listen_fd_, 8) < 0) return false;
-    server_thread_ = std::thread([this] { Loop(); });
+    server_thread_ = std::thread([this, fd = listen_fd_] { Loop(fd); });
     return true;
   }
 
@@ -104,9 +104,9 @@ class MiniRestServer {
   }
 
  private:
-  void Loop() {
+  void Loop(int listen_fd) {
     while (!stopping_) {
-      int fd = ::accept(listen_fd_, nullptr, nullptr);
+      int fd = ::accept(listen_fd, nullptr, nullptr);
       if (fd < 0) break;
       HandleConnection(fd);
       ::close(fd);
@@ -128,7 +128,8 @@ class MiniRestServer {
       std::string lower;
       lower.reserve(header_end);
       for (size_t i = 0; i < header_end; ++i) {
-        lower.push_back(static_cast<char>(std::tolower(raw[i])));
+        lower.push_back(
+            static_cast<char>(std::tolower(static_cast<unsigned char>(raw[i]))));
       }
       auto pos = lower.find("content-length:");
       if (pos != std::string::npos) {
@@ -160,7 +161,9 @@ class MiniRestServer {
   static std::string HeaderValue(const std::string& headers, std::string_view name) {
     std::string lower;
     lower.reserve(headers.size());
-    for (char c : headers) lower.push_back(static_cast<char>(std::tolower(c)));
+    for (char c : headers) {
+      lower.push_back(static_cast<char>(std::tolower(static_cast<unsigned char>(c))));
+    }
     auto pos = lower.find(std::string(name) + ":");
     if (pos == std::string::npos) return "";
     auto value_start = pos + name.size() + 1;
@@ -276,10 +279,13 @@ TEST(RestCatalogSessionTest, RefreshAndCommitUseTableSessionFromResponseConfig)
   EXPECT_TRUE(requests[0].path.find("/v1/config") != std::string::npos);
   EXPECT_EQ(requests[0].auth_marker, "init");
   EXPECT_EQ(requests[1].method, "GET");
+  EXPECT_TRUE(requests[1].path.find("/tables/tbl1") != std::string::npos);
   EXPECT_EQ(requests[1].auth_marker, "catalog");
   EXPECT_EQ(requests[2].method, "GET");
+  EXPECT_TRUE(requests[2].path.find("/tables/tbl1") != std::string::npos);
   EXPECT_EQ(requests[2].auth_marker, "table:tbl-token-1");
   EXPECT_EQ(requests[3].method, "POST");
+  EXPECT_TRUE(requests[3].path.find("/tables/tbl1") != std::string::npos);
   EXPECT_EQ(requests[3].auth_marker, "table:tbl-token-1");
 }