resolve comments

Author: zhjwpku

src/iceberg/table.cc

@@ -323,6 +323,10 @@ Result<std::shared_ptr<FastAppend>> StaticTable::NewFastAppend() {
   return NotSupported("Cannot create a fast append for a static table");
 }
 
+Result<std::shared_ptr<MergeAppend>> StaticTable::NewMergeAppend() {
+  return NotSupported("Cannot create a merge append for a static table");
+}
+
 Result<std::shared_ptr<SnapshotManager>> StaticTable::NewSnapshotManager() {
   return NotSupported("Cannot create a snapshot manager for a static table");
 }

src/iceberg/table.h

@@ -246,6 +246,8 @@ class ICEBERG_EXPORT StaticTable : public Table {
 
   Result<std::shared_ptr<FastAppend>> NewFastAppend() override;
 
+  Result<std::shared_ptr<MergeAppend>> NewMergeAppend() override;
+
   Result<std::shared_ptr<SnapshotManager>> NewSnapshotManager() override;
 
  private:

src/iceberg/test/table_test.cc

@@ -160,6 +160,7 @@ TEST(StaticTableTest, NewMutatingOperationsAreNotSupported) {
   EXPECT_THAT(table->NewUpdateStatistics(), IsError(ErrorKind::kNotSupported));
   EXPECT_THAT(table->NewUpdatePartitionStatistics(), IsError(ErrorKind::kNotSupported));
   EXPECT_THAT(table->NewFastAppend(), IsError(ErrorKind::kNotSupported));
+  EXPECT_THAT(table->NewMergeAppend(), IsError(ErrorKind::kNotSupported));
   EXPECT_THAT(table->NewSnapshotManager(), IsError(ErrorKind::kNotSupported));
 }
 

src/iceberg/update/snapshot_update.cc

@@ -399,29 +399,6 @@ Result<std::unordered_map<std::string, std::string>> SnapshotUpdate::ComputeSumm
   return summary;
 }
 
-SnapshotSummaryBuilder SnapshotUpdate::BuildManifestCountSummary(
-    std::span<const ManifestFile> manifests, int32_t replaced_manifests_count) {
-  SnapshotSummaryBuilder summary;
-  int32_t manifests_created = 0;
-  int32_t manifests_kept = 0;
-  int64_t snapshot_id = SnapshotId();
-
-  for (const auto& manifest : manifests) {
-    if (manifest.added_snapshot_id == snapshot_id) {
-      ++manifests_created;
-    } else if (manifest.added_snapshot_id != kInvalidSnapshotId) {
-      ++manifests_kept;
-    }
-  }
-
-  summary.Set(SnapshotSummaryFields::kManifestsCreated,
-              std::to_string(manifests_created));
-  summary.Set(SnapshotSummaryFields::kManifestsKept, std::to_string(manifests_kept));
-  summary.Set(SnapshotSummaryFields::kManifestsReplaced,
-              std::to_string(replaced_manifests_count));
-  return summary;
-}
-
 Status SnapshotUpdate::CleanAll() {
   for (const auto& manifest_list : manifest_lists_) {
     std::ignore = DeleteFile(manifest_list);

src/iceberg/update/snapshot_update.h

@@ -215,8 +215,6 @@ class ICEBERG_EXPORT SnapshotUpdate : public PendingUpdate {
 
   std::string ManifestPath();
   std::string ManifestListPath();
-  SnapshotSummaryBuilder BuildManifestCountSummary(
-      std::span<const ManifestFile> manifests, int32_t replaced_manifests_count);
   SnapshotSummaryBuilder& summary_builder() { return summary_; }
   SnapshotSummaryBuilder BuildManifestCountSummary(
       std::span<const ManifestFile> manifests, int32_t replaced_manifests_count);