Skip to content

Commit 515eb3d

Browse files
committed
Add initializer names to SnapshotsTable and HistoryTable
1 parent 077e8d0 commit 515eb3d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/iceberg/inspect/history_table.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ HistoryTable::HistoryTable(std::shared_ptr<Table> table)
3535

3636
HistoryTable::~HistoryTable() = default;
3737

38-
std::shared_ptr<Schema> HistoryTable::GetSchema() const {
38+
std::shared_ptr<Schema> HistoryTable::GetSchema() const override {
3939
return std::make_shared<Schema>(
4040
std::vector<SchemaField>{
4141
SchemaField::MakeRequired(1, "made_current_at", timestamp_tz()),
@@ -46,7 +46,7 @@ std::shared_ptr<Schema> HistoryTable::GetSchema() const {
4646
}
4747

4848
TableIdentifier HistoryTable::CreateName(const TableIdentifier& source_name) {
49-
return TableIdentifier{source_name.ns, source_name.name + ".history"};
49+
return TableIdentifier{.ns = source_name.ns, .name = source_name.name + ".history"};
5050
}
5151

5252
Result<std::unique_ptr<HistoryTable>> HistoryTable::Make(std::shared_ptr<Table> table) {

src/iceberg/inspect/snapshots_table.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ SnapshotsTable::SnapshotsTable(std::shared_ptr<Table> table)
3535

3636
SnapshotsTable::~SnapshotsTable() = default;
3737

38-
std::shared_ptr<Schema> SnapshotsTable::GetSchema() const {
38+
std::shared_ptr<Schema> SnapshotsTable::GetSchema() const override {
3939
return std::make_shared<Schema>(
4040
std::vector<SchemaField>{
4141
SchemaField::MakeRequired(1, "committed_at", timestamp_tz()),
@@ -52,7 +52,7 @@ std::shared_ptr<Schema> SnapshotsTable::GetSchema() const {
5252
}
5353

5454
TableIdentifier SnapshotsTable::CreateName(const TableIdentifier& source_name) {
55-
return TableIdentifier{source_name.ns, source_name.name + ".snapshots"};
55+
return TableIdentifier{.ns = source_name.ns, .name = source_name.name + ".snapshots"};
5656
}
5757

5858
Result<std::unique_ptr<SnapshotsTable>> SnapshotsTable::Make(

0 commit comments

Comments
 (0)