Skip to content

Commit 5bbeff5

Browse files
committed
refactor: Cast format_version to int8_t in TableMetadataBuilder and suppress unused variable warnings
1 parent 36cc69d commit 5bbeff5

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/iceberg/table_metadata.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ Result<std::unique_ptr<TableMetadata>> TableMetadata::Make(
223223

224224
ICEBERG_RETURN_UNEXPECTED(PropertyUtil::ValidateCommitProperties(properties));
225225

226-
return TableMetadataBuilder::BuildFromEmpty(format_version)
226+
return TableMetadataBuilder::BuildFromEmpty(static_cast<int8_t>(format_version))
227227
->SetLocation(location)
228228
.SetCurrentSchema(std::move(fresh_schema), last_column_id)
229229
.SetDefaultPartitionSpec(std::move(fresh_spec))
@@ -1586,6 +1586,7 @@ TableMetadataBuilder& TableMetadataBuilder::SetDefaultPartitionSpec(int32_t spec
15861586
TableMetadataBuilder& TableMetadataBuilder::AddPartitionSpec(
15871587
std::shared_ptr<PartitionSpec> spec) {
15881588
ICEBERG_BUILDER_ASSIGN_OR_RETURN(auto _, impl_->AddPartitionSpec(*spec));
1589+
(void)_;
15891590
return *this;
15901591
}
15911592

@@ -1615,6 +1616,7 @@ TableMetadataBuilder& TableMetadataBuilder::SetDefaultSortOrder(int32_t order_id
16151616
TableMetadataBuilder& TableMetadataBuilder::AddSortOrder(
16161617
std::shared_ptr<SortOrder> order) {
16171618
ICEBERG_BUILDER_ASSIGN_OR_RETURN(auto _, impl_->AddSortOrder(*order));
1619+
(void)_;
16181620
return *this;
16191621
}
16201622

0 commit comments

Comments
 (0)