Skip to content

Commit 6245ca7

Browse files
build: Fix nanoarrow download URL pattern and formatting
The current nanoarrow download logic hardcoded a specific download URL which would break CI when a new nanoarrow version is released and the old one is removed from the primary Apache download mirror. This commit refactors the nanoarrow toolchain resolution to follow the exact same pattern as the arrow dependency, which includes robust fallback URLs (including archive.apache.org) to ensure the dependency can always be downloaded even after newer versions are released. The ARROW_SOURCE_URL has also been updated to include the archive fallback URL to improve its resiliency. Additionally, this ensures proper CMake formatting based on the pre-commit checks. Co-authored-by: wgtmac <4684607+wgtmac@users.noreply.github.com>
1 parent 1c2d1db commit 6245ca7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

cmake_modules/IcebergThirdpartyToolchain.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,10 @@ function(resolve_nanoarrow_dependency)
275275
${FC_DECLARE_COMMON_OPTIONS}
276276
URL ${NANOARROW_SOURCE_URL}
277277
URL_HASH "SHA256=${ICEBERG_NANOARROW_BUILD_SHA256_CHECKSUM}"
278-
FIND_PACKAGE_ARGS
279-
NAMES
280-
nanoarrow
281-
CONFIG)
278+
FIND_PACKAGE_ARGS
279+
NAMES
280+
nanoarrow
281+
CONFIG)
282282
fetchcontent_makeavailable(nanoarrow)
283283

284284
if(nanoarrow_SOURCE_DIR)

0 commit comments

Comments
 (0)