drop unnecessary signing mutex

Author: plusplusjiajia

src/iceberg/catalog/rest/auth/sigv4_auth_manager.cc

@@ -20,7 +20,6 @@
 #include "iceberg/catalog/rest/auth/sigv4_auth_manager.h"
 
 #include <cstdlib>
-#include <mutex>
 #include <sstream>
 
 #include <aws/core/Aws.h>
@@ -154,12 +153,9 @@ Result<HTTPRequest> SigV4AuthSession::Authenticate(const HTTPRequest& request) {
                                 Aws::Utils::HashingUtils::Base64Encode(sha256));
   }
 
-  {
-    std::lock_guard<std::mutex> lock(signing_mutex_);
-    if (!signer_->SignRequest(*aws_request)) {
-      return std::unexpected<Error>(
-          Error{ErrorKind::kAuthenticationFailed, "SigV4 signing failed"});
-    }
+  if (!signer_->SignRequest(*aws_request)) {
+    return std::unexpected<Error>(Error{.kind = ErrorKind::kAuthenticationFailed,
+                                        .message = "SigV4 signing failed"});
   }
 
   HTTPRequest signed_request{.method = delegate_request.method,
@@ -269,10 +265,10 @@ std::string SigV4AuthManager::ResolveSigningRegion(
     return it->second;
   }
   if (const char* env = std::getenv("AWS_REGION")) {
-    return std::string(env);
+    return {env};
   }
   if (const char* env = std::getenv("AWS_DEFAULT_REGION")) {
-    return std::string(env);
+    return {env};
   }
   return "us-east-1";
 }

src/iceberg/catalog/rest/auth/sigv4_auth_manager.h

@@ -20,7 +20,6 @@
 #pragma once
 
 #include <memory>
-#include <mutex>
 #include <string>
 #include <unordered_map>
 
@@ -48,8 +47,8 @@ namespace iceberg::rest::auth {
 ///
 /// See https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_sigv.html
 ///
-/// Thread safety: Authenticate() is thread-safe; concurrent signing calls are
-/// serialized by an internal mutex.
+/// Thread safety: Authenticate() is thread-safe as long as the delegate
+/// session is.
 class ICEBERG_REST_EXPORT SigV4AuthSession : public AuthSession {
  public:
   /// SHA-256 hash of empty string, used for requests with no body.
@@ -87,8 +86,6 @@ class ICEBERG_REST_EXPORT SigV4AuthSession : public AuthSession {
   std::shared_ptr<Aws::Auth::AWSCredentialsProvider> credentials_provider_;
   std::unique_ptr<Aws::Client::AWSAuthV4Signer> signer_;
   std::unordered_map<std::string, std::string> effective_properties_;
-  // AWSAuthV4Signer::SignRequest mutates shared signer state.
-  mutable std::mutex signing_mutex_;
 };
 
 /// \brief An AuthManager that produces SigV4AuthSession instances.

src/iceberg/catalog/rest/http_client.cc

@@ -82,7 +82,7 @@ std::unordered_map<std::string, std::string> MergeHeaders(
 }
 
 cpr::Header ToCprHeader(const auth::HTTPRequest& request) {
-  return cpr::Header(request.headers.begin(), request.headers.end());
+  return {request.headers.begin(), request.headers.end()};
 }
 
 /// \brief Append URL-encoded query parameters to a URL, sorted by key.

src/iceberg/catalog/rest/meson.build

@@ -98,7 +98,4 @@ iceberg_rest_auth_headers = [
 if aws_sdk_core_dep.found()
     iceberg_rest_auth_headers += ['auth/sigv4_auth_manager.h']
 endif
-install_headers(
-    iceberg_rest_auth_headers,
-    subdir: 'iceberg/catalog/rest/auth',
-)
+install_headers(iceberg_rest_auth_headers, subdir: 'iceberg/catalog/rest/auth')

src/iceberg/test/sigv4_auth_test.cc

@@ -209,7 +209,7 @@ TEST_F(SigV4AuthTest, TableSessionInheritsProperties) {
   auto catalog_session = manager_result.value()->CatalogSession(client_, properties);
   ASSERT_THAT(catalog_session, IsOk());
 
-  iceberg::TableIdentifier table_id{iceberg::Namespace{{"ns1"}}, "table1"};
+  iceberg::TableIdentifier table_id{.ns = iceberg::Namespace{{"ns1"}}, .name = "table1"};
   std::unordered_map<std::string, std::string> table_props;
   auto table_session = manager_result.value()->TableSession(table_id, table_props,
                                                             catalog_session.value());
@@ -474,7 +474,7 @@ TEST_F(SigV4AuthTest, TableSessionOverridesProperties) {
       {AuthProperties::kSigV4SigningRegion, "ap-southeast-1"},
   };
 
-  iceberg::TableIdentifier table_id{iceberg::Namespace{{"db1"}}, "table1"};
+  iceberg::TableIdentifier table_id{.ns = iceberg::Namespace{{"db1"}}, .name = "table1"};
   auto table_session = manager_result.value()->TableSession(table_id, table_props,
                                                             catalog_session.value());
   ASSERT_THAT(table_session, IsOk());
@@ -506,7 +506,7 @@ TEST_F(SigV4AuthTest, TableSessionInheritsContextualOverrides) {
       {{AuthProperties::kSigV4SigningRegion, "eu-west-1"}}, catalog_session.value());
   ASSERT_THAT(ctx_session, IsOk());
 
-  iceberg::TableIdentifier table_id{iceberg::Namespace{{"db1"}}, "table1"};
+  iceberg::TableIdentifier table_id{.ns = iceberg::Namespace{{"db1"}}, .name = "table1"};
   auto table_session = manager_result.value()->TableSession(table_id, /*properties=*/{},
                                                             ctx_session.value());
   ASSERT_THAT(table_session, IsOk());