Skip to content

Commit 6a88541

Browse files
authored
chore: use new package name avro-cpp (#208)
1 parent b717675 commit 6a88541

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

cmake_modules/IcebergThirdpartyToolchain.cmake

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -179,26 +179,27 @@ function(resolve_avro_dependency)
179179
OFF
180180
CACHE BOOL "" FORCE)
181181

182-
fetchcontent_declare(Avro
182+
fetchcontent_declare(avro-cpp
183183
${FC_DECLARE_COMMON_OPTIONS}
184184
# TODO: switch to Apache Avro 1.13.0 once released.
185185
GIT_REPOSITORY https://github.com/apache/avro.git
186-
GIT_TAG 82a2bc8b034de34626e2ab8bf091234122474d50
186+
GIT_TAG e6c308780e876b4c11a470b9900995947f7b0fb5
187187
SOURCE_SUBDIR
188188
lang/c++
189189
FIND_PACKAGE_ARGS
190190
NAMES
191-
Avro
191+
avro-cpp
192192
CONFIG)
193193

194-
fetchcontent_makeavailable(Avro)
194+
fetchcontent_makeavailable(avro-cpp)
195195

196-
if(avro_SOURCE_DIR)
197-
if(NOT TARGET Avro::avrocpp_static)
198-
add_library(Avro::avrocpp_static INTERFACE IMPORTED)
199-
target_link_libraries(Avro::avrocpp_static INTERFACE avrocpp_s)
200-
target_include_directories(Avro::avrocpp_static
201-
INTERFACE ${avro_BINARY_DIR} ${avro_SOURCE_DIR}/lang/c++)
196+
if(avro-cpp_SOURCE_DIR)
197+
if(NOT TARGET avro-cpp::avrocpp_static)
198+
add_library(avro-cpp::avrocpp_static INTERFACE IMPORTED)
199+
target_link_libraries(avro-cpp::avrocpp_static INTERFACE avrocpp_s)
200+
target_include_directories(avro-cpp::avrocpp_static
201+
INTERFACE ${avro-cpp_BINARY_DIR}
202+
${avro-cpp_SOURCE_DIR}/lang/c++)
202203
endif()
203204

204205
set(AVRO_VENDORED TRUE)

src/iceberg/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,29 +130,29 @@ if(ICEBERG_BUILD_BUNDLE)
130130
"$<IF:$<TARGET_EXISTS:iceberg_static>,iceberg_static,iceberg_shared>"
131131
"$<IF:$<TARGET_EXISTS:Arrow::arrow_static>,Arrow::arrow_static,Arrow::arrow_shared>"
132132
"$<IF:$<TARGET_EXISTS:Parquet::parquet_static>,Parquet::parquet_static,Parquet::parquet_shared>"
133-
"$<IF:$<TARGET_EXISTS:Avro::avrocpp_static>,Avro::avrocpp_static,Avro::avrocpp_shared>"
133+
"$<IF:$<TARGET_EXISTS:avro-cpp::avrocpp_static>,avro-cpp::avrocpp_static,avro-cpp::avrocpp_shared>"
134134
)
135135
list(APPEND
136136
ICEBERG_BUNDLE_SHARED_BUILD_INTERFACE_LIBS
137137
"$<IF:$<TARGET_EXISTS:iceberg_shared>,iceberg_shared,iceberg_static>"
138138
"$<IF:$<TARGET_EXISTS:Arrow::arrow_shared>,Arrow::arrow_shared,Arrow::arrow_static>"
139139
"$<IF:$<TARGET_EXISTS:Parquet::parquet_shared>,Parquet::parquet_shared,Parquet::parquet_static>"
140-
"$<IF:$<TARGET_EXISTS:Avro::avrocpp_shared>,Avro::avrocpp_shared,Avro::avrocpp_static>"
140+
"$<IF:$<TARGET_EXISTS:avro-cpp::avrocpp_shared>,avro-cpp::avrocpp_shared,avro-cpp::avrocpp_static>"
141141
)
142142

143143
list(APPEND
144144
ICEBERG_BUNDLE_STATIC_INSTALL_INTERFACE_LIBS
145145
"$<IF:$<TARGET_EXISTS:Iceberg::iceberg_static>,Iceberg::iceberg_static,Iceberg::iceberg_shared>"
146146
"$<IF:$<BOOL:${ARROW_VENDORED}>,Iceberg::arrow_static,$<IF:$<TARGET_EXISTS:Arrow::arrow_static>,Arrow::arrow_static,Arrow::arrow_shared>>"
147147
"$<IF:$<BOOL:${ARROW_VENDORED}>,Iceberg::parquet_static,$<IF:$<TARGET_EXISTS:Parquet::parquet_static>,Parquet::parquet_static,Parquet::parquet_shared>>"
148-
"$<IF:$<BOOL:${AVRO_VENDORED}>,Iceberg::avrocpp_s,$<IF:$<TARGET_EXISTS:Avro::avrocpp_static>,Avro::avrocpp_static,Avro::avrocpp_shared>>"
148+
"$<IF:$<BOOL:${AVRO_VENDORED}>,Iceberg::avrocpp_s,$<IF:$<TARGET_EXISTS:avro-cpp::avrocpp_static>,avro-cpp::avrocpp_static,avro-cpp::avrocpp_shared>>"
149149
)
150150
list(APPEND
151151
ICEBERG_BUNDLE_SHARED_INSTALL_INTERFACE_LIBS
152152
"$<IF:$<TARGET_EXISTS:Iceberg::iceberg_shared>,Iceberg::iceberg_shared,Iceberg::iceberg_static>"
153153
"$<IF:$<BOOL:${ARROW_VENDORED}>,Iceberg::arrow_static,$<IF:$<TARGET_EXISTS:Arrow::arrow_shared>,Arrow::arrow_shared,Arrow::arrow_static>>"
154154
"$<IF:$<BOOL:${ARROW_VENDORED}>,Iceberg::parquet_static,$<IF:$<TARGET_EXISTS:Parquet::parquet_shared>,Parquet::parquet_shared,Parquet::parquet_static>>"
155-
"$<IF:$<BOOL:${AVRO_VENDORED}>,Iceberg::avrocpp_s,$<IF:$<TARGET_EXISTS:Avro::avrocpp_shared>,Avro::avrocpp_shared,Avro::avrocpp_static>>"
155+
"$<IF:$<BOOL:${AVRO_VENDORED}>,Iceberg::avrocpp_s,$<IF:$<TARGET_EXISTS:avro-cpp::avrocpp_shared>,avro-cpp::avrocpp_shared,avro-cpp::avrocpp_static>>"
156156
)
157157

158158
add_iceberg_lib(iceberg_bundle

0 commit comments

Comments
 (0)