feat: Implement NoopAuthManager and integrate AuthManager into RestCatalog

Author: shuxu.li

src/iceberg/catalog/rest/auth/auth_managers.cc

@@ -77,7 +77,6 @@ class NoopAuthManager : public AuthManager {
 AuthManagerRegistry& GetRegistry() {
   static AuthManagerRegistry registry = [] {
     AuthManagerRegistry r;
-    // Register built-in "none" auth manager
     r[AuthProperties::kAuthTypeNone] =
         []([[maybe_unused]] std::string_view name,
            [[maybe_unused]] const std::unordered_map<std::string, std::string>& props)

src/iceberg/catalog/rest/rest_catalog.cc

@@ -139,7 +139,6 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make(
   ICEBERG_ASSIGN_OR_RAISE(auto server_config,
                           FetchServerConfig(*paths, config, init_session));
 
-  // Merge client config with server defaults and overrides
   std::unique_ptr<RestCatalogProperties> final_config = RestCatalogProperties::FromMap(
       MergeConfigs(server_config.defaults, config.configs(), server_config.overrides));
 

src/iceberg/test/auth_manager_test.cc

@@ -80,29 +80,6 @@ TEST_F(AuthManagerTest, UnknownAuthTypeReturnsInvalidArgument) {
   EXPECT_THAT(result, HasErrorMessage("Unknown authentication type"));
 }
 
-// Verifies that known but unimplemented auth type returns NotImplemented
-TEST_F(AuthManagerTest, KnownButUnimplementedAuthType) {
-  std::unordered_map<std::string, std::string> properties = {
-      {AuthProperties::kAuthType, "basic"}};
-
-  auto result = AuthManagers::Load("test-catalog", properties);
-  EXPECT_THAT(result, IsError(ErrorKind::kNotImplemented));
-  EXPECT_THAT(result, HasErrorMessage("not yet supported"));
-}
-
-// Verifies that OAuth2 auth type is inferred from credential or token properties
-TEST_F(AuthManagerTest, InferOAuth2FromProperties) {
-  // From credential
-  auto result1 = AuthManagers::Load(
-      "test", {{AuthProperties::kOAuth2Credential, "client_id:client_secret"}});
-  EXPECT_THAT(result1, IsError(ErrorKind::kNotImplemented));
-
-  // From token
-  auto result2 =
-      AuthManagers::Load("test", {{AuthProperties::kOAuth2Token, "bearer-token"}});
-  EXPECT_THAT(result2, IsError(ErrorKind::kNotImplemented));
-}
-
 // Verifies custom auth manager registration
 TEST_F(AuthManagerTest, RegisterCustomAuthManager) {
   AuthManagers::Register(