refactor: rename partitionSpecById to partition_spec_by_id

Author: Sandeep Gottimukkala

src/iceberg/json_serde.cc

@@ -1753,7 +1753,7 @@ Result<std::unique_ptr<TableRequirement>> TableRequirementFromJson(
 
 Result<DataFile> DataFileFromJson(
     const nlohmann::json& json,
-    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partitionSpecById,
+    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partition_spec_by_id,
     const Schema& schema) {
   if (!json.is_object()) {
     return JsonParseError("DataFile must be a JSON object: {}", SafeDumpJson(json));
@@ -1788,8 +1788,8 @@ Result<DataFile> DataFileFromJson(
                             SafeDumpJson(partition_vals));
     }
     std::vector<Literal> literals;
-    auto it = partitionSpecById.find(df.partition_spec_id.value_or(-1));
-    if (it == partitionSpecById.end()) {
+    auto it = partition_spec_by_id.find(df.partition_spec_id.value_or(-1));
+    if (it == partition_spec_by_id.end()) {
       return JsonParseError("Invalid partition spec id: {}",
                             df.partition_spec_id.value_or(-1));
     }
@@ -1897,7 +1897,7 @@ Result<DataFile> DataFileFromJson(
 Result<std::vector<std::shared_ptr<FileScanTask>>> FileScanTasksFromJson(
     const nlohmann::json& json,
     const std::vector<std::shared_ptr<DataFile>>& delete_files,
-    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partitionSpecById,
+    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partition_spec_by_id,
     const Schema& schema) {
   if (!json.is_array()) {
     return JsonParseError("Cannot parse file scan tasks from non-array: {}",
@@ -1913,7 +1913,7 @@ Result<std::vector<std::shared_ptr<FileScanTask>>> FileScanTasksFromJson(
     ICEBERG_ASSIGN_OR_RAISE(auto data_file_json,
                             GetJsonValue<nlohmann::json>(task_json, kDataFile));
     ICEBERG_ASSIGN_OR_RAISE(auto data_file,
-                            DataFileFromJson(data_file_json, partitionSpecById, schema));
+                            DataFileFromJson(data_file_json, partition_spec_by_id, schema));
 
     std::vector<std::shared_ptr<DataFile>> task_delete_files;
     if (task_json.contains(kDeleteFileReferences) &&

src/iceberg/json_serde_internal.h

@@ -424,16 +424,16 @@ ICEBERG_EXPORT Result<std::unique_ptr<TableRequirement>> TableRequirementFromJso
 /// Binary fields (lower-bounds, upper-bounds, key-metadata) are base64-encoded.
 ///
 /// \param json The JSON object representing a `DataFile`.
-/// \param partitionSpecById Map from spec ID to PartitionSpec for type-aware partition
+/// \param partition_spec_by_id Map from spec ID to PartitionSpec for type-aware partition
 /// parsing.
-/// \param schema The table schema, used with partitionSpecById to resolve partition
+/// \param schema The table schema, used with partition_spec_by_id to resolve partition
 /// types.
 /// \return A `DataFile` object or an error if the conversion fails.
 ICEBERG_EXPORT Result<DataFile> DataFileFromJson(const nlohmann::json& json);
 
 ICEBERG_EXPORT Result<DataFile> DataFileFromJson(
     const nlohmann::json& json,
-    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partitionSpecById,
+    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partition_spec_by_id,
     const Schema& schema);
 
 /// \brief Deserializes a JSON array of file scan tasks.
@@ -442,15 +442,15 @@ ICEBERG_EXPORT Result<DataFile> DataFileFromJson(
 ///
 /// \param json The JSON array of file scan task objects.
 /// \param delete_files Delete files indexed by the tasks' delete-file-references.
-/// \param partitionSpecById Map from spec ID to PartitionSpec for type-aware partition
+/// \param partition_spec_by_id Map from spec ID to PartitionSpec for type-aware partition
 /// parsing.
-/// \param schema The table schema, used with partitionSpecById to resolve partition
+/// \param schema The table schema, used with partition_spec_by_id to resolve partition
 /// types.
 /// \return A vector of `FileScanTask` objects or an error if the conversion fails.
 ICEBERG_EXPORT Result<std::vector<std::shared_ptr<FileScanTask>>> FileScanTasksFromJson(
     const nlohmann::json& json,
     const std::vector<std::shared_ptr<DataFile>>& delete_files,
-    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partitionSpecById,
+    const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& partition_spec_by_id,
     const Schema& schema);
 
 }  // namespace iceberg