refactor: Add content property to DataFile and initialize sin_zero in sockaddr structure

Author: Joe-Abraham

src/iceberg/test/manifest_reader_test.cc

@@ -131,7 +131,8 @@ class TestManifestReader : public testing::TestWithParam<int8_t> {
       std::optional<int64_t> content_offset = std::nullopt,
       std::optional<int64_t> content_size = std::nullopt) {
     return std::make_unique<DataFile>(
-        DataFile{.file_path = path,
+        DataFile{.content = content,
+                 .file_path = path,
                  .file_format = FileFormatType::kParquet,
                  .partition = partition,
                  .record_count = 1,

src/iceberg/test/rest_catalog_integration_test.cc

@@ -81,6 +81,7 @@ bool CheckServiceReady(uint16_t port) {
       .sin_family = AF_INET,
       .sin_port = htons(port),
       .sin_addr = {.s_addr = htonl(INADDR_LOOPBACK)},
+      .sin_zero = {},
   };
   bool result =
       (connect(sock, reinterpret_cast<struct sockaddr*>(&addr), sizeof(addr)) == 0);

src/iceberg/test/test_resource.h

@@ -40,8 +40,8 @@ static std::string GetResourcePath(const std::string& file_name) {
 }
 
 /// \brief Read table metadata from a JSON file and return the Result directly
-static Result<std::unique_ptr<TableMetadata>> ReadTableMetadataFromResource(
-    const std::string& file_name) {
+[[maybe_unused]] static Result<std::unique_ptr<TableMetadata>>
+ReadTableMetadataFromResource(const std::string& file_name) {
   std::filesystem::path path{GetResourcePath(file_name)};
   if (!std::filesystem::exists(path)) {
     return InvalidArgument("File does not exist: {}", path.string());