fix(rest): build resource paths from final config (#482)

Author: plusplusjiajia

src/iceberg/catalog/rest/resource_paths.cc

@@ -38,14 +38,6 @@ Result<std::unique_ptr<ResourcePaths>> ResourcePaths::Make(std::string base_uri,
 ResourcePaths::ResourcePaths(std::string base_uri, const std::string& prefix)
     : base_uri_(std::move(base_uri)), prefix_(prefix.empty() ? "" : (prefix + "/")) {}
 
-Status ResourcePaths::SetBaseUri(const std::string& base_uri) {
-  if (base_uri.empty()) {
-    return InvalidArgument("Base URI is empty");
-  }
-  base_uri_ = base_uri;
-  return {};
-}
-
 Result<std::string> ResourcePaths::Config() const {
   return std::format("{}/v1/config", base_uri_);
 }

src/iceberg/catalog/rest/resource_paths.h

@@ -23,7 +23,6 @@
 #include <string>
 
 #include "iceberg/catalog/rest/iceberg_rest_export.h"
-#include "iceberg/catalog/rest/type_fwd.h"
 #include "iceberg/result.h"
 #include "iceberg/type_fwd.h"
 
@@ -44,9 +43,6 @@ class ICEBERG_REST_EXPORT ResourcePaths {
   static Result<std::unique_ptr<ResourcePaths>> Make(std::string base_uri,
                                                      const std::string& prefix);
 
-  /// \brief Set the base URI of the REST catalog server.
-  Status SetBaseUri(const std::string& base_uri);
-
   /// \brief Get the /v1/config endpoint path.
   Result<std::string> Config() const;
 

src/iceberg/catalog/rest/rest_catalog.cc

@@ -132,7 +132,9 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make(
 
   // Update resource paths based on the final config
   ICEBERG_ASSIGN_OR_RAISE(auto final_uri, final_config->Uri());
-  ICEBERG_RETURN_UNEXPECTED(paths->SetBaseUri(std::string(TrimTrailingSlash(final_uri))));
+  ICEBERG_ASSIGN_OR_RAISE(
+      paths, ResourcePaths::Make(std::string(TrimTrailingSlash(final_uri)),
+                                 final_config->Get(RestCatalogProperties::kPrefix)));
 
   return std::shared_ptr<RestCatalog>(
       new RestCatalog(std::move(final_config), std::move(file_io), std::move(paths),