fix ci

Author: wgtmac

.clang-tidy

@@ -21,7 +21,6 @@ Checks: |
   clang-analyzer-*,
   google-*,
   modernize-*,
-  misc-include-cleaner,
   readability-identifier-naming,
   readability-isolate-declaration,
   -modernize-use-nodiscard,
@@ -42,7 +41,5 @@ CheckOptions:
     value:  '_'
   - key:    modernize-use-scoped-lock.WarnOnSingleLocks
     value:  'false'
-  - key:    misc-include-cleaner.IgnoreHeaders
-    value:  'arrow/.*;avro/.*;aws/.*;cpr/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;thrift/.*'
 
 HeaderFilterRegex: 'src/iceberg|example'

.github/workflows/aws_test.yml

@@ -200,6 +200,7 @@ jobs:
       - name: Build and test Iceberg
         shell: bash
         env:
+          CMAKE_TOOLCHAIN_FILE: /usr/local/share/vcpkg/scripts/buildsystems/vcpkg.cmake
           CMAKE_PREFIX_PATH: /usr/local/share/vcpkg/installed/x64-linux
         run: |
           meson setup builddir -Dsigv4=enabled

src/iceberg/transaction.cc

@@ -87,7 +87,8 @@ const TableMetadata& TransactionContext::current() const {
   return metadata_builder->current();
 }
 
-Result<std::unique_ptr<LocationProvider>> TransactionContext::LocationProvider() const {
+Result<std::unique_ptr<LocationProvider>> TransactionContext::NewLocationProvider()
+    const {
   return iceberg::LocationProvider::Make(current().location, current().properties);
 }
 

src/iceberg/transaction.h

@@ -188,7 +188,7 @@ class ICEBERG_EXPORT TransactionContext {
   const TableMetadata* base() const;
   const TableMetadata& current() const;
   std::string MetadataFileLocation(std::string_view filename) const;
-  Result<std::unique_ptr<LocationProvider>> LocationProvider() const;
+  Result<std::unique_ptr<LocationProvider>> NewLocationProvider() const;
 
   std::shared_ptr<Table> table;
   std::unique_ptr<TableMetadataBuilder> metadata_builder;

src/iceberg/update/merging_snapshot_update.cc

@@ -816,7 +816,7 @@ MergingSnapshotUpdate::MergeDVs() {
     return result;
   }
 
-  ICEBERG_ASSIGN_OR_RAISE(auto location_provider, ctx_->LocationProvider());
+  ICEBERG_ASSIGN_OR_RAISE(auto location_provider, ctx_->NewLocationProvider());
   auto output_path = location_provider->NewDataLocation(
       std::format("merged-dvs-{}-{}.puffin", SnapshotId(), ++dv_merge_attempt_));