fix: use std::move when pass by value

Author: SYaoJun

requirements.txt

@@ -2,3 +2,4 @@ meson==1.3.0
 ninja==1.13.0
 mkdocs==1.6.1
 mkdocs-material==9.6.22
+pre-commit==4.5.1

src/iceberg/util/config.h

@@ -67,10 +67,13 @@ class ConfigBase {
   template <typename T>
   class Entry {
    public:
-    Entry(std::string key, const T& val,
+    Entry(std::string key, T val,
           std::function<std::string(const T&)> to_str = internal::DefaultToString<T>,
           std::function<T(const std::string&)> from_str = internal::DefaultFromString<T>)
-        : key_{std::move(key)}, default_{val}, to_str_{to_str}, from_str_{from_str} {}
+        : key_{std::move(key)},
+          default_{std::move(val)},
+          to_str_{std::move(to_str)},
+          from_str_{std::move(from_str)} {}
 
    private:
     const std::string key_;

src/iceberg/util/lazy.h

@@ -38,10 +38,10 @@ class Lazy {
 
   template <typename R, typename... Args>
   struct Trait<R (*)(Args...)> {
-    using ReturnType = R::value_type;
+    using ReturnType = typename R::value_type;
   };
 
-  using T = Trait<decltype(InitFunc)>::ReturnType;
+  using T = typename Trait<decltype(InitFunc)>::ReturnType;
 
  public:
   template <typename... Args>