refactor: Rename loop variable in JSON parsing to improve clarity

Joe-Abraham · Joe-Abraham · commit ad5820ec337e · 2026-03-24T10:47:03.000+05:30
diff --git a/src/iceberg/location_provider.cc b/src/iceberg/location_provider.cc
@@ -90,7 +90,8 @@ std::string DirsFromHash(int32_t hash) {
 
 std::string ComputeHash(std::string_view file_name) {
   int32_t hash_value = 0;
-  MurmurHash3_x86_32(file_name.data(), file_name.size(), 0, &hash_value);
+  MurmurHash3_x86_32(file_name.data(), static_cast<int>(file_name.size()), 0,
+                     &hash_value);
   return DirsFromHash(hash_value);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,8 @@ std::string DirsFromHash(int32_t hash) {`
`90`	`90`
`91`	`91`	`std::string ComputeHash(std::string_view file_name) {`
`92`	`92`	`int32_t hash_value = 0;`
`93`		`- MurmurHash3_x86_32(file_name.data(), file_name.size(), 0, &hash_value);`
	`93`	`+ MurmurHash3_x86_32(file_name.data(), static_cast<int>(file_name.size()), 0,`
	`94`	`+ &hash_value);`
`94`	`95`	`return DirsFromHash(hash_value);`
`95`	`96`	`}`
`96`	`97`