review comment

Author: Innocent

src/iceberg/CMakeLists.txt

@@ -31,7 +31,7 @@ set(ICEBERG_SOURCES
     expression/expression.cc
     expression/expressions.cc
     expression/inclusive_metrics_evaluator.cc
-    expression/json_internal.cc
+    expression/json_serde.cc
     expression/literal.cc
     expression/manifest_evaluator.cc
     expression/predicate.cc

src/iceberg/expression/json_internal.cc src/iceberg/expression/json_serde.ccsrc/iceberg/expression/json_internal.cc renamed to src/iceberg/expression/json_serde.cc

@@ -17,8 +17,6 @@
  * under the License.
  */
 
-#include "iceberg/expression/json_internal.h"
-
 #include <format>
 #include <string>
 #include <utility>
@@ -27,6 +25,7 @@
 #include <nlohmann/json.hpp>
 
 #include "iceberg/expression/expressions.h"
+#include "iceberg/expression/json_serde_internal.h"
 #include "iceberg/expression/literal.h"
 #include "iceberg/util/json_util_internal.h"
 #include "iceberg/util/macros.h"

src/iceberg/expression/json_internal.h …iceberg/expression/json_serde_internal.hsrc/iceberg/expression/json_internal.h renamed to src/iceberg/expression/json_serde_internal.h src/iceberg/expression/json_internal.h renamed to src/iceberg/expression/json_serde_internal.h

@@ -26,27 +26,15 @@
 
 #include "iceberg/expression/expression.h"
 #include "iceberg/expression/expressions.h"
-#include "iceberg/expression/json_internal.h"
+#include "iceberg/expression/json_serde_internal.h"
 #include "iceberg/expression/literal.h"
 #include "iceberg/expression/predicate.h"
 #include "iceberg/expression/term.h"
 #include "iceberg/test/matchers.h"
 
 namespace iceberg {
 
-class ExpressionJsonTest : public ::testing::Test {
- protected:
-  // Helper to test round-trip serialization
-  // Uses string comparison since expressions may have different internal identity
-  // but the same semantic meaning (i.e., ToString() output matches)
-  void TestRoundTrip(const Expression& expr) {
-    auto json = ToJson(expr);
-    auto result = ExpressionFromJson(json);
-    ASSERT_THAT(result, IsOk()) << "Failed to parse JSON: " << json.dump();
-    EXPECT_EQ(expr.ToString(), result.value()->ToString())
-        << "Round-trip failed.\nJSON: " << json.dump();
-  }
-};
+class ExpressionJsonTest : public ::testing::Test {};
 
 // Test boolean constant expressions
 TEST_F(ExpressionJsonTest, TrueExpression) {