ci: relax include cleaner lint

Author: wgtmac

.clang-tidy

@@ -21,7 +21,6 @@ Checks: |
   clang-analyzer-*,
   google-*,
   modernize-*,
-  misc-include-cleaner,
   readability-identifier-naming,
   readability-isolate-declaration,
   -modernize-use-nodiscard,
@@ -42,7 +41,5 @@ CheckOptions:
     value:  '_'
   - key:    modernize-use-scoped-lock.WarnOnSingleLocks
     value:  'false'
-  - key:    misc-include-cleaner.IgnoreHeaders
-    value:  'arrow/.*;avro/.*;aws/.*;cpr/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;thrift/.*'
 
 HeaderFilterRegex: 'src/iceberg|example'

.github/workflows/aws_test.yml

@@ -92,7 +92,7 @@ jobs:
           path: /usr/local/share/vcpkg/installed
           key: vcpkg-x64-linux-aws-sdk-cpp-s3-${{ matrix.s3 }}-sigv4-${{ matrix.sigv4 }}-${{ hashFiles('.github/workflows/aws_test.yml') }}
       - name: Install AWS SDK via vcpkg
-        if: ${{ startsWith(matrix.runs-on, 'ubuntu') && matrix.bundle_awssdk == 'OFF' && steps.vcpkg-cache.outputs.cache-hit != 'true' }}
+        if: ${{ startsWith(matrix.runs-on, 'ubuntu') && matrix.bundle_awssdk == 'OFF' }}
         shell: bash
         # Retry to ride out transient GitHub/mirror download failures (504s).
         run: |
@@ -169,7 +169,6 @@ jobs:
           path: /usr/local/share/vcpkg/installed
           key: vcpkg-x64-linux-aws-sdk-cpp-core-${{ hashFiles('.github/workflows/aws_test.yml') }}
       - name: Install AWS SDK via vcpkg
-        if: ${{ steps.vcpkg-cache.outputs.cache-hit != 'true' }}
         shell: bash
         # Retry to ride out transient GitHub/mirror download failures (504s).
         run: |

.github/workflows/cpp-linter.yml

@@ -44,6 +44,7 @@ jobs:
     runs-on: ubuntu-26.04
     permissions:
       contents: read
+      issues: write
       pull-requests: write
     env:
       SCCACHE_DIR: ${{ github.workspace }}/.sccache
@@ -103,7 +104,7 @@ jobs:
           version: 22
           files-changed-only: true
           lines-changed-only: true
-          thread-comments: true
+          thread-comments: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
           ignore: 'build|cmake_modules|ci|src/iceberg/catalog/hive/gen-cpp'
           database: build
           verbosity: 'debug'