Commit b65352a
build: silence benign MSVC C4251/C4275 dll-interface warnings (#768)
## What
Add `/wd4251` and `/wd4275` in `meson.build`, applied only where the
compiler accepts them.
## Why
The MSVC build prints tens of thousands of lines of C4251/C4275 warnings
about exported classes (like `TableProperties` and `ConfigBase`/`Entry`)
that hold standard-library members. These are harmless when everything
is built as one DLL with one compiler, but they bury the warnings that
actually matter in the Windows logs. The flags are ignored on GCC and
Clang, which don't have these warnings.
For reference, the average Meson Windows build logs ~22k of these
warning lines (971 unique messages), drowning the handful of real
warnings in the same run:
https://github.com/apache/iceberg-cpp/actions/runs/27870777076/job/82482181520
Co-authored-by: Abanoub Doss <abanoub.doss@gmail.com>1 parent dd0db17 commit b65352a
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
0 commit comments