Skip to content

Commit b6cfce1

Browse files
authored
ci: Remove unused strategy sections from non-matrix jobs (#566)
## Summary Removes unnecessary `strategy` sections from jobs that don't use a matrix. ## Changes - Removed `strategy: fail-fast: false` from `ubuntu`, `macos`, `windows` jobs in `test.yml` - Removed `strategy: fail-fast: false` from `sanitizer-test` job in `sanitizer_test.yml` ## Rationale The `fail-fast` option only applies to matrix jobs where multiple configurations run in parallel. For single jobs without a matrix, this setting has no effect and generates schema warnings. Jobs with matrices (like `meson` and `verify`) retain their strategy configuration.
1 parent b022fe7 commit b6cfce1

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

.github/workflows/sanitizer_test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ jobs:
3737
sanitizer-test:
3838
name: "ASAN and UBSAN Tests"
3939
runs-on: ubuntu-24.04
40-
strategy:
41-
fail-fast: false
4240
steps:
4341
- name: Checkout iceberg-cpp
4442
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/test.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ jobs:
4141
name: AMD64 Ubuntu 24.04
4242
runs-on: ubuntu-24.04
4343
timeout-minutes: 30
44-
strategy:
45-
fail-fast: false
4644
steps:
4745
- name: Checkout iceberg-cpp
4846
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -65,8 +63,6 @@ jobs:
6563
name: AArch64 macOS 26
6664
runs-on: macos-26
6765
timeout-minutes: 30
68-
strategy:
69-
fail-fast: false
7066
steps:
7167
- name: Checkout iceberg-cpp
7268
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -80,8 +76,6 @@ jobs:
8076
name: AMD64 Windows 2025
8177
runs-on: windows-2025
8278
timeout-minutes: 60
83-
strategy:
84-
fail-fast: false
8579
steps:
8680
- name: Checkout iceberg-cpp
8781
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

0 commit comments

Comments
 (0)