build fix

Author: Innocent

src/iceberg/manifest/manifest_group.cc

@@ -321,36 +321,30 @@ ManifestGroup::ReadEntries() {
     ICEBERG_ASSIGN_OR_RAISE(bool should_match, manifest_evaluator->Evaluate(manifest));
     if (!should_match) {
       // Skip this manifest because it doesn't match partition filter
-      scan_counters_.skipped_data_manifests++;
       continue;
     }
 
     if (ignore_deleted_) {
       // only scan manifests that have entries other than deletes
       if (!manifest.has_added_files() && !manifest.has_existing_files()) {
-        scan_counters_.skipped_data_manifests++;
         continue;
       }
     }
 
     if (ignore_existing_) {
       // only scan manifests that have entries other than existing
       if (!manifest.has_added_files() && !manifest.has_deleted_files()) {
-        scan_counters_.skipped_data_manifests++;
         continue;
       }
     }
 
-    scan_counters_.scanned_data_manifests++;
-
     // Read manifest entries
     ICEBERG_ASSIGN_OR_RAISE(auto reader, MakeReader(manifest));
     ICEBERG_ASSIGN_OR_RAISE(auto entries,
                             ignore_deleted_ ? reader->LiveEntries() : reader->Entries());
 
     for (auto& entry : entries) {
       if (ignore_existing_ && entry.status == ManifestStatus::kExisting) {
-        scan_counters_.skipped_data_files++;
         continue;
       }
 
@@ -360,7 +354,6 @@ ManifestGroup::ReadEntries() {
       }
 
       if (!manifest_entry_predicate_(entry)) {
-        scan_counters_.skipped_data_files++;
         continue;
       }
 

src/iceberg/manifest/manifest_group.h

@@ -39,16 +39,6 @@
 
 namespace iceberg {
 
-/// \brief Counters for tracking scan metrics during manifest processing.
-struct ICEBERG_EXPORT ScanMetricsCounters {
-  int64_t scanned_data_manifests = 0;
-  int64_t skipped_data_manifests = 0;
-  int64_t scanned_delete_manifests = 0;
-  int64_t skipped_delete_manifests = 0;
-  int64_t skipped_data_files = 0;
-  int64_t skipped_delete_files = 0;
-};
-
 /// \brief Context passed to task creation functions.
 struct ICEBERG_EXPORT TaskContext {
  public:
@@ -130,9 +120,6 @@ class ICEBERG_EXPORT ManifestGroup : public ErrorCollector {
   /// \param column_ids Field IDs of columns whose statistics should be preserved.
   ManifestGroup& ColumnsToKeepStats(std::unordered_set<int32_t> column_ids);
 
-  /// \brief Returns the scan metrics counters accumulated during plan operations.
-  const ScanMetricsCounters& scan_counters() const { return scan_counters_; }
-
   /// \brief Plan scan tasks for all matching data files.
   Result<std::vector<std::shared_ptr<FileScanTask>>> PlanFiles();
 
@@ -175,7 +162,6 @@ class ICEBERG_EXPORT ManifestGroup : public ErrorCollector {
   bool ignore_deleted_ = false;
   bool ignore_existing_ = false;
   bool ignore_residuals_ = false;
-  ScanMetricsCounters scan_counters_;
 };
 
 }  // namespace iceberg

src/iceberg/metrics/counter.h

@@ -22,6 +22,7 @@
 #include <atomic>
 #include <cstdint>
 #include <string_view>
+#include <utility>
 
 #include "iceberg/iceberg_export.h"
 

src/iceberg/table_scan.cc

@@ -535,9 +535,7 @@ Result<std::vector<std::shared_ptr<FileScanTask>>> DataTableScan::PlanFiles() co
     manifest_group->IgnoreResiduals();
   }
 
-  ICEBERG_ASSIGN_OR_RAISE(auto tasks, manifest_group->PlanFiles());
-
-  return tasks;
+  return manifest_group->PlanFiles();
 }
 
 // IncrementalAppendScan implementation

src/iceberg/table_scan.h

@@ -129,6 +129,7 @@ struct TableScanContext {
   std::optional<int64_t> to_snapshot_id;
   std::string branch{};
   std::optional<int64_t> min_rows_requested;
+
   // Validate the context parameters to see if they have conflicts.
   [[nodiscard]] Status Validate() const;
 };

src/iceberg/transaction.cc

@@ -19,7 +19,6 @@
  */
 #include "iceberg/transaction.h"
 
-#include <chrono>
 #include <format>
 #include <memory>
 #include <optional>
@@ -51,7 +50,6 @@
 #include "iceberg/util/checked_cast.h"
 #include "iceberg/util/location_util.h"
 #include "iceberg/util/macros.h"
-#include "iceberg/util/string_util.h"
 
 namespace iceberg {
 
@@ -341,6 +339,7 @@ Result<std::shared_ptr<Table>> Transaction::Commit() {
   ICEBERG_CHECK(!committed_, "Transaction already committed");
   ICEBERG_CHECK(last_update_committed_,
                 "Cannot commit transaction when previous update is not committed");
+
   const auto& updates = ctx_->metadata_builder->changes();
   if (updates.empty()) {
     committed_ = true;
@@ -375,6 +374,7 @@ Result<std::shared_ptr<Table>> Transaction::Commit() {
   // Mark as committed and update table reference
   committed_ = true;
   ctx_->table = std::move(commit_result.value());
+
   return ctx_->table;
 }
 

src/iceberg/transaction.h

@@ -20,7 +20,6 @@
 
 #pragma once
 
-#include <chrono>
 #include <cstdint>
 #include <memory>
 #include <optional>