Skip to content

Commit c2d49bd

Browse files
author
Innocent
committed
linter
1 parent 779fe03 commit c2d49bd

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/iceberg/test/metrics_test.cc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,15 @@ TEST(NoopTimerTest, IsNoopAndAlwaysZero) {
129129

130130
TEST(DefaultMetricsContextTest, SameNameReturnsSameObject) {
131131
DefaultMetricsContext ctx;
132-
auto c1 = ctx.GetCounter("foo");
133-
auto c2 = ctx.GetCounter("foo");
132+
auto c1 = ctx.GetCounter("foo", CounterUnit::kCount);
133+
auto c2 = ctx.GetCounter("foo", CounterUnit::kCount);
134134
EXPECT_EQ(c1.get(), c2.get());
135135
}
136136

137137
TEST(DefaultMetricsContextTest, DifferentNamesReturnDifferentObjects) {
138138
DefaultMetricsContext ctx;
139-
auto c1 = ctx.GetCounter("a");
140-
auto c2 = ctx.GetCounter("b");
139+
auto c1 = ctx.GetCounter("a", CounterUnit::kCount);
140+
auto c2 = ctx.GetCounter("b", CounterUnit::kCount);
141141
EXPECT_NE(c1.get(), c2.get());
142142
}
143143

@@ -150,15 +150,15 @@ TEST(DefaultMetricsContextTest, TimerSameNameReturnsSameObject) {
150150

151151
TEST(NullMetricsContextTest, ReturnsNoopInstances) {
152152
MetricsContext& null_ctx = MetricsContext::Null();
153-
EXPECT_TRUE(null_ctx.GetCounter("x")->IsNoop());
153+
EXPECT_TRUE(null_ctx.GetCounter("x", CounterUnit::kCount)->IsNoop());
154154
EXPECT_TRUE(null_ctx.GetTimer("y")->IsNoop());
155155
}
156156

157157
TEST(NullMetricsContextTest, ReturnsSameSharedPtrEachCall) {
158158
// Verify the static-shared_ptr fix: no new control block per call.
159159
MetricsContext& null_ctx = MetricsContext::Null();
160-
auto c1 = null_ctx.GetCounter("a");
161-
auto c2 = null_ctx.GetCounter("b");
160+
auto c1 = null_ctx.GetCounter("a", CounterUnit::kCount);
161+
auto c2 = null_ctx.GetCounter("b", CounterUnit::kCount);
162162
EXPECT_EQ(c1.get(), c2.get()); // same noop singleton
163163
auto t1 = null_ctx.GetTimer("x");
164164
auto t2 = null_ctx.GetTimer("y");

0 commit comments

Comments
 (0)