Fix shadowed function and class/struct friend declaration warnings

Author: Joe-Abraham

src/iceberg/expression/projections.h

@@ -43,7 +43,7 @@ class ICEBERG_EXPORT ProjectionEvaluator {
   Result<std::shared_ptr<Expression>> Project(const std::shared_ptr<Expression>& expr);
 
  private:
-  friend class Projections;
+  friend struct Projections;
 
   /// \brief Create a ProjectionEvaluator.
   ///

src/iceberg/schema.cc

@@ -150,7 +150,7 @@ std::string Schema::ToString() const {
   return repr;
 }
 
-bool Schema::Equals(const Schema& other) const {
+bool Schema::EqualsSchema(const Schema& other) const {
   return schema_id_ == other.schema_id_ && fields_ == other.fields_ &&
          identifier_field_ids_ == other.identifier_field_ids_;
 }

src/iceberg/schema.h

@@ -184,11 +184,13 @@ class ICEBERG_EXPORT Schema : public StructType {
   /// \return Error status if the schema is invalid.
   Status Validate(int32_t format_version) const;
 
-  friend bool operator==(const Schema& lhs, const Schema& rhs) { return lhs.Equals(rhs); }
+  friend bool operator==(const Schema& lhs, const Schema& rhs) {
+    return lhs.EqualsSchema(rhs);
+  }
 
  private:
   /// \brief Compare two schemas for equality.
-  bool Equals(const Schema& other) const;
+  bool EqualsSchema(const Schema& other) const;
 
   const int32_t schema_id_;
   // Field IDs that uniquely identify rows in the table.