Skip to content

Commit c4913d4

Browse files
committed
temporarily fix issue with avro by disabling hidden visibility
1 parent 3f198e4 commit c4913d4

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

cmake_modules/IcebergBuildUtils.cmake

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,6 @@ function(add_iceberg_lib LIB_NAME)
152152

153153
string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
154154
target_compile_definitions(${LIB_NAME}_shared PRIVATE ${VISIBILITY_NAME}_EXPORTING)
155-
set_target_properties(${LIB_NAME}_shared
156-
PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET
157-
hidden
158-
VISIBILITY_INLINES_HIDDEN 1)
159155

160156
if(MSVC_TOOLCHAIN)
161157
target_compile_options(${LIB_NAME}_shared PRIVATE /bigobj)

src/iceberg/CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,13 @@ add_iceberg_lib(iceberg
156156
OUTPUTS
157157
ICEBERG_LIBRARIES)
158158

159+
if(ICEBERG_BUILD_SHARED)
160+
set_target_properties(iceberg_shared
161+
PROPERTIES C_VISIBILITY_PRESET hidden
162+
CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN
163+
1)
164+
endif()
165+
159166
iceberg_install_all_headers(iceberg)
160167

161168
add_subdirectory(catalog)

0 commit comments

Comments
 (0)