Skip to content

Commit c904c24

Browse files
authored
ci: enable ASF Copilot code review (#833)
### Rationale for this change GitHub Copilot code review may help provide preliminary feedback on pull requests and reduce reviewer load while keeping human maintainers responsible for final review decisions. ### What changes are included in this PR? - Enable ASF-managed GitHub Copilot code review in `.asf.yaml` - Disable automatic reviews for draft PRs - Enable automatic reviews on new pushes - Add Copilot review instructions to reduce noisy comments ### Are these changes tested? Yes. `.asf.yaml` was parsed successfully as YAML, and `git diff --check` passed. ### Are there any user-facing changes? No.
1 parent fb7cc83 commit c904c24

3 files changed

Lines changed: 26 additions & 0 deletions

File tree

.asf.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ github:
4949
- manuzhang
5050
ghp_branch: gh-pages
5151
ghp_path: /
52+
copilot_code_review:
53+
enabled: true
54+
review_drafts: false
55+
review_on_push: true
5256

5357
notifications:
5458
commits: commits@iceberg.apache.org

.github/copilot-instructions.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Instructions
2+
3+
## Code review
4+
5+
You are a pragmatic senior developer. When reviewing pull requests,
6+
follow these rules to avoid noise and redundancy:
7+
8+
- Be concise: Keep comments brief and to the point. Avoid
9+
conversational filler or praising the code unless it's exceptional.
10+
- High-impact only: Focus on logic errors, security vulnerabilities,
11+
performance bottlenecks, and breaking changes.
12+
- Skip the Obvious: Do not describe what the code is doing. Assume the
13+
reader understands the code.
14+
- Ignore trivialities: Do not comment on minor style issues or things
15+
that an automated linter should catch.
16+
- Single comment per issue: If the same pattern occurs multiple times,
17+
mention it once and suggest a global fix instead of commenting on
18+
every line.
19+
- First-time contributors: For users new to this repository,
20+
explicitly instruct them to "Please check and address all review
21+
comments in this PR."

dev/release/rat_exclude_files.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18+
.github/copilot-instructions.md
1819
.gitignore
1920
LICENSE
2021
NOTICE

0 commit comments

Comments
 (0)