refactor: expand Snapshot and TableMetadata initialization in tests

Author: Joe-Abraham

src/iceberg/test/table_metadata_builder_test.cc

@@ -1137,8 +1137,22 @@ TEST(TableMetadataBuilderTest, RemoveSnapshotRef) {
   auto builder = TableMetadataBuilder::BuildFrom(base.get());
 
   // Add multiple snapshots
-  builder->AddSnapshot(std::make_shared<Snapshot>(Snapshot{.snapshot_id = 1}));
-  builder->AddSnapshot(std::make_shared<Snapshot>(Snapshot{.snapshot_id = 2}));
+  builder->AddSnapshot(
+      std::make_shared<Snapshot>(Snapshot{.snapshot_id = 1,
+                                          .parent_snapshot_id = std::nullopt,
+                                          .sequence_number = 0,
+                                          .timestamp_ms = {},
+                                          .manifest_list = "",
+                                          .summary = {},
+                                          .schema_id = std::nullopt}));
+  builder->AddSnapshot(
+      std::make_shared<Snapshot>(Snapshot{.snapshot_id = 2,
+                                          .parent_snapshot_id = std::nullopt,
+                                          .sequence_number = 0,
+                                          .timestamp_ms = {},
+                                          .manifest_list = "",
+                                          .summary = {},
+                                          .schema_id = std::nullopt}));
 
   // Add multiple refs
   ICEBERG_UNWRAP_OR_FAIL(auto ref1, SnapshotRef::MakeBranch(1));
@@ -1162,8 +1176,22 @@ TEST(TableMetadataBuilderTest, RemoveSnapshot) {
   auto builder = TableMetadataBuilder::BuildFrom(base.get());
 
   // Add multiple snapshots
-  builder->AddSnapshot(std::make_shared<Snapshot>(Snapshot{.snapshot_id = 1}));
-  builder->AddSnapshot(std::make_shared<Snapshot>(Snapshot{.snapshot_id = 2}));
+  builder->AddSnapshot(
+      std::make_shared<Snapshot>(Snapshot{.snapshot_id = 1,
+                                          .parent_snapshot_id = std::nullopt,
+                                          .sequence_number = 0,
+                                          .timestamp_ms = {},
+                                          .manifest_list = "",
+                                          .summary = {},
+                                          .schema_id = std::nullopt}));
+  builder->AddSnapshot(
+      std::make_shared<Snapshot>(Snapshot{.snapshot_id = 2,
+                                          .parent_snapshot_id = std::nullopt,
+                                          .sequence_number = 0,
+                                          .timestamp_ms = {},
+                                          .manifest_list = "",
+                                          .summary = {},
+                                          .schema_id = std::nullopt}));
 
   ICEBERG_UNWRAP_OR_FAIL(auto metadata, builder->Build());
   ASSERT_EQ(metadata->snapshots.size(), 2);
@@ -1182,8 +1210,22 @@ TEST(TableMetadataBuilderTest, RemoveSnapshotNotExist) {
   auto builder = TableMetadataBuilder::BuildFrom(base.get());
 
   // Add multiple snapshots
-  builder->AddSnapshot(std::make_shared<Snapshot>(Snapshot{.snapshot_id = 1}));
-  builder->AddSnapshot(std::make_shared<Snapshot>(Snapshot{.snapshot_id = 2}));
+  builder->AddSnapshot(
+      std::make_shared<Snapshot>(Snapshot{.snapshot_id = 1,
+                                          .parent_snapshot_id = std::nullopt,
+                                          .sequence_number = 0,
+                                          .timestamp_ms = {},
+                                          .manifest_list = "",
+                                          .summary = {},
+                                          .schema_id = std::nullopt}));
+  builder->AddSnapshot(
+      std::make_shared<Snapshot>(Snapshot{.snapshot_id = 2,
+                                          .parent_snapshot_id = std::nullopt,
+                                          .sequence_number = 0,
+                                          .timestamp_ms = {},
+                                          .manifest_list = "",
+                                          .summary = {},
+                                          .schema_id = std::nullopt}));
 
   ICEBERG_UNWRAP_OR_FAIL(auto metadata, builder->Build());
   ASSERT_EQ(metadata->snapshots.size(), 2);

src/iceberg/test/table_test.cc

@@ -88,8 +88,28 @@ class TypedTableTest : public ::testing::Test {
         std::vector<SchemaField>{SchemaField::MakeRequired(1, "id", int64()),
                                  SchemaField::MakeOptional(2, "name", string())},
         1);
-    metadata_ = std::make_shared<TableMetadata>(
-        TableMetadata{.format_version = 2, .schemas = {schema}, .current_schema_id = 1});
+    metadata_ = std::make_shared<TableMetadata>(TableMetadata{.format_version = 2,
+                                                              .table_uuid = "",
+                                                              .location = "",
+                                                              .last_sequence_number = 0,
+                                                              .last_updated_ms = {},
+                                                              .last_column_id = 0,
+                                                              .schemas = {schema},
+                                                              .current_schema_id = 1,
+                                                              .partition_specs = {},
+                                                              .default_spec_id = 0,
+                                                              .last_partition_id = 0,
+                                                              .properties = {},
+                                                              .current_snapshot_id = 0,
+                                                              .snapshots = {},
+                                                              .snapshot_log = {},
+                                                              .metadata_log = {},
+                                                              .sort_orders = {},
+                                                              .default_sort_order_id = 0,
+                                                              .refs = {},
+                                                              .statistics = {},
+                                                              .partition_statistics = {},
+                                                              .next_row_id = 0});
   }
 
   Result<std::shared_ptr<T>> MakeTable(const std::string& name) {