feat: Implement NoopAuthManager and integrate AuthManager into RestCatalog

Author: shuxu.li

src/iceberg/catalog/rest/auth/auth_managers.cc

@@ -35,13 +35,13 @@ using AuthManagerRegistry =
 
 /// \brief Known authentication types that are defined in the Iceberg spec.
 const std::unordered_set<std::string, StringHash, StringEqual>& KnownAuthTypes() {
-  static const std::unordered_set<std::string, StringHash, StringEqual> types = {
+  static const std::unordered_set<std::string, StringHash, StringEqual> kAuthTypes = {
       AuthProperties::kAuthTypeNone,
       AuthProperties::kAuthTypeBasic,
       AuthProperties::kAuthTypeOAuth2,
       AuthProperties::kAuthTypeSigV4,
   };
-  return types;
+  return kAuthTypes;
 }
 
 // Infer the authentication type from properties.
@@ -66,7 +66,7 @@ std::string InferAuthType(
 class NoopAuthManager : public AuthManager {
  public:
   Result<std::shared_ptr<AuthSession>> CatalogSession(
-      [[maybe_unused]] HttpClient& shared_client,
+      [[maybe_unused]] HttpClient& client,
       [[maybe_unused]] const std::unordered_map<std::string, std::string>& properties)
       override {
     return AuthSession::MakeDefault({});

src/iceberg/catalog/rest/rest_catalog.cc

@@ -69,15 +69,14 @@ std::unordered_set<Endpoint> GetDefaultEndpoints() {
 }
 
 /// \brief Fetch server configuration from the REST catalog server.
-Result<CatalogConfig> FetchServerConfig(
-    const ResourcePaths& paths, const RestCatalogProperties& current_config,
-    const std::shared_ptr<auth::AuthSession>& session) {
+Result<CatalogConfig> FetchServerConfig(const ResourcePaths& paths,
+                                        const RestCatalogProperties& current_config,
+                                        auth::AuthSession& session) {
   ICEBERG_ASSIGN_OR_RAISE(auto config_path, paths.Config());
   HttpClient client(current_config.ExtractHeaders());
 
-  // Get authentication headers
   std::unordered_map<std::string, std::string> auth_headers;
-  ICEBERG_RETURN_UNEXPECTED(session->Authenticate(auth_headers));
+  ICEBERG_RETURN_UNEXPECTED(session.Authenticate(auth_headers));
 
   ICEBERG_ASSIGN_OR_RAISE(const auto response,
                           client.Get(config_path, /*params=*/{}, auth_headers,
@@ -137,7 +136,7 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make(
   ICEBERG_ASSIGN_OR_RAISE(auto init_session,
                           auth_manager->InitSession(init_client, config.configs()));
   ICEBERG_ASSIGN_OR_RAISE(auto server_config,
-                          FetchServerConfig(*paths, config, init_session));
+                          FetchServerConfig(*paths, config, *init_session));
 
   std::unique_ptr<RestCatalogProperties> final_config = RestCatalogProperties::FromMap(
       MergeConfigs(server_config.defaults, config.configs(), server_config.overrides));

src/iceberg/test/meson.build

@@ -104,7 +104,12 @@ iceberg_tests = {
 if get_option('rest').enabled()
     iceberg_tests += {
         'rest_catalog_test': {
-            'sources': files('rest_json_serde_test.cc', 'rest_util_test.cc'),
+            'sources': files(
+                'auth_manager_test.cc',
+                'endpoint_test.cc',
+                'rest_json_serde_test.cc',
+                'rest_util_test.cc',
+            ),
             'dependencies': [iceberg_rest_dep],
         },
     }