remove

Author: HeartLinked

src/iceberg/expression/literal.cc

@@ -32,22 +32,6 @@
 
 namespace iceberg {
 
-/// \brief Create a literal from int64 value and long-type TypeId.
-Result<Literal> CreateLongTypeLiteral(int64_t value, TypeId type_id) {
-  switch (type_id) {
-    case TypeId::kLong:
-      return Literal::Long(value);
-    case TypeId::kTime:
-      return Literal::Time(value);
-    case TypeId::kTimestamp:
-      return Literal::Timestamp(value);
-    case TypeId::kTimestampTz:
-      return Literal::TimestampTz(value);
-    default:
-      return NotSupported("Unsupported long type: {}", static_cast<int>(type_id));
-  }
-}
-
 /// \brief LiteralSerializer handles serialization/deserialization operations for Literal.
 /// This is an internal implementation class.
 class LiteralSerializer {
@@ -578,7 +562,7 @@ Result<Literal> LiteralSerializer::FromBytes(std::span<const uint8_t> data,
                                data.size());
       }
 
-      return CreateLongTypeLiteral(value, type_id);
+      return Literal(value, type);
     }
 
     case TypeId::kFloat: {

test/literal_test.cc

@@ -498,20 +498,6 @@ TEST(LiteralSerializationTest, TypePromotion) {
   EXPECT_EQ(double_bytes->size(), 8);
 }
 
-// Null value serialization tests
-TEST(LiteralSerializationTest, NullValues) {
-  // Empty byte array should deserialize to null
-  auto null_result = Literal::Deserialize({}, int32());
-  ASSERT_TRUE(null_result.has_value());
-  EXPECT_TRUE(null_result->IsNull());
-
-  // Null value serialization should return empty byte array
-  auto null_literal = Literal::Null(int32());
-  auto bytes_result = null_literal.Serialize();
-  ASSERT_TRUE(bytes_result.has_value());
-  EXPECT_TRUE(bytes_result->empty());
-}
-
 // Edge case serialization tests
 TEST(LiteralSerializationTest, EdgeCases) {
   // Negative integers