fix linter

wgtmac · wgtmac · commit e4bb44b71ed7 · 2026-07-14T17:58:40.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -43,6 +43,6 @@ CheckOptions:
   - key:    modernize-use-scoped-lock.WarnOnSingleLocks
     value:  'false'
   - key:    misc-include-cleaner.IgnoreHeaders
-    value:  'arrow/.*;avro/.*;aws/.*;cpr/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;sqlite3\.h;thrift/.*;utf8proc\.h;zlib\.h'
+    value:  'arrow/.*;avro/.*;aws/.*;cpr/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;thrift/.*'
 
 HeaderFilterRegex: 'src/iceberg|example'
diff --git a/src/iceberg/data/data_writer.cc b/src/iceberg/data/data_writer.cc
@@ -20,7 +20,9 @@
 #include "iceberg/data/data_writer.h"
 
 #include <map>
+#include <utility>
 
+#include "iceberg/data/writer.h"  // IWYU pragma: keep
 #include "iceberg/file_writer.h"
 #include "iceberg/manifest/manifest_entry.h"
 #include "iceberg/partition_spec.h"
diff --git a/src/iceberg/data/deletion_vector_writer.cc b/src/iceberg/data/deletion_vector_writer.cc
@@ -19,20 +19,29 @@
 
 #include "iceberg/data/deletion_vector_writer.h"
 
+#include <cstdint>
 #include <format>
 #include <map>
+#include <memory>
 #include <optional>
 #include <string>
+#include <string_view>
 #include <unordered_map>
 #include <utility>
 #include <vector>
 
-#include "iceberg/file_io.h"
+#include "iceberg/data/writer.h"
+#include "iceberg/deletes/position_delete_index.h"
+#include "iceberg/deletes/roaring_position_bitmap.h"
+#include "iceberg/file_format.h"
+#include "iceberg/file_io.h"  // IWYU pragma: keep
 #include "iceberg/manifest/manifest_entry.h"
 #include "iceberg/metadata_columns.h"
 #include "iceberg/partition_spec.h"
 #include "iceberg/puffin/file_metadata.h"
 #include "iceberg/puffin/puffin_writer.h"
+#include "iceberg/result.h"
+#include "iceberg/row/partition_values.h"
 #include "iceberg/util/content_file_util.h"
 #include "iceberg/util/macros.h"
 #include "iceberg/util/string_util.h"
diff --git a/src/iceberg/data/dv_util.cc b/src/iceberg/data/dv_util.cc
@@ -28,6 +28,7 @@
 #include "iceberg/deletes/position_delete_index.h"
 #include "iceberg/file_io.h"
 #include "iceberg/manifest/manifest_entry.h"
+#include "iceberg/result.h"
 #include "iceberg/util/content_file_util.h"
 #include "iceberg/util/macros.h"
 
diff --git a/src/iceberg/data/equality_delete_writer.cc b/src/iceberg/data/equality_delete_writer.cc
@@ -20,7 +20,9 @@
 #include "iceberg/data/equality_delete_writer.h"
 
 #include <map>
+#include <utility>
 
+#include "iceberg/data/writer.h"  // IWYU pragma: keep
 #include "iceberg/file_writer.h"
 #include "iceberg/manifest/manifest_entry.h"
 #include "iceberg/partition_spec.h"
diff --git a/src/iceberg/data/position_delete_writer.cc b/src/iceberg/data/position_delete_writer.cc
@@ -21,12 +21,14 @@
 
 #include <map>
 #include <set>
+#include <utility>
 #include <vector>
 
 #include <nanoarrow/nanoarrow.h>
 
 #include "iceberg/arrow/nanoarrow_status_internal.h"
 #include "iceberg/arrow_c_data_guard_internal.h"
+#include "iceberg/data/writer.h"  // IWYU pragma: keep
 #include "iceberg/file_writer.h"
 #include "iceberg/manifest/manifest_entry.h"
 #include "iceberg/metadata_columns.h"
diff --git a/src/iceberg/deletes/position_delete_index.cc b/src/iceberg/deletes/position_delete_index.cc
@@ -19,16 +19,23 @@
 
 #include "iceberg/deletes/position_delete_index.h"
 
+#include <zconf.h>
 #include <zlib.h>
 
 #include <array>
 #include <cstddef>
+#include <cstdint>
 #include <cstring>
 #include <limits>
+#include <memory>
+#include <span>
 #include <string_view>
 #include <utility>
+#include <vector>
 
+#include "iceberg/deletes/roaring_position_bitmap.h"
 #include "iceberg/manifest/manifest_entry.h"
+#include "iceberg/result.h"
 #include "iceberg/util/endian.h"
 #include "iceberg/util/macros.h"
 
diff --git a/src/iceberg/deletes/roaring_position_bitmap.cc b/src/iceberg/deletes/roaring_position_bitmap.cc
@@ -19,9 +19,11 @@
 
 #include "iceberg/deletes/roaring_position_bitmap.h"
 
+#include <cstdint>
 #include <cstring>
 #include <exception>
 #include <limits>
+#include <string_view>
 #include <utility>
 #include <vector>
 
diff --git a/src/iceberg/test/delete_filter_test.cc b/src/iceberg/test/delete_filter_test.cc
@@ -25,6 +25,7 @@
 #include <string>
 #include <unordered_map>
 #include <unordered_set>
+#include <utility>
 #include <vector>
 
 #include <arrow/array.h>
@@ -37,6 +38,7 @@
 #include "iceberg/data/deletion_vector_writer.h"
 #include "iceberg/data/equality_delete_writer.h"
 #include "iceberg/data/position_delete_writer.h"
+#include "iceberg/deletes/position_delete_index.h"
 #include "iceberg/file_format.h"
 #include "iceberg/file_io.h"
 #include "iceberg/file_reader.h"
diff --git a/src/iceberg/test/delete_loader_test.cc b/src/iceberg/test/delete_loader_test.cc
@@ -20,6 +20,7 @@
 #include "iceberg/data/delete_loader.h"
 
 #include <optional>
+#include <utility>
 
 #include <arrow/array.h>
 #include <arrow/c/bridge.h>
@@ -37,12 +38,14 @@
 #include "iceberg/manifest/manifest_entry.h"
 #include "iceberg/parquet/parquet_register.h"
 #include "iceberg/partition_spec.h"
+#include "iceberg/result.h"
 #include "iceberg/row/partition_values.h"
 #include "iceberg/schema.h"
 #include "iceberg/schema_field.h"
 #include "iceberg/schema_internal.h"
 #include "iceberg/test/matchers.h"
 #include "iceberg/type.h"
+#include "iceberg/util/macros.h"
 #include "iceberg/util/struct_like_set.h"
 
 namespace iceberg {
diff --git a/src/iceberg/test/deletion_vector_writer_test.cc b/src/iceberg/test/deletion_vector_writer_test.cc
@@ -19,10 +19,12 @@
 
 #include "iceberg/data/deletion_vector_writer.h"
 
+#include <cstdint>
 #include <functional>
 #include <memory>
 #include <optional>
 #include <string>
+#include <string_view>
 #include <utility>
 #include <vector>
 
@@ -37,9 +39,11 @@
 #include "iceberg/partition_spec.h"
 #include "iceberg/puffin/file_metadata.h"
 #include "iceberg/puffin/puffin_reader.h"
+#include "iceberg/result.h"
 #include "iceberg/row/partition_values.h"
 #include "iceberg/test/matchers.h"
 #include "iceberg/test/mock_io.h"
+#include "iceberg/util/macros.h"
 #include "iceberg/version.h"
 
 namespace iceberg {
diff --git a/src/iceberg/test/file_scan_task_reader_test.cc b/src/iceberg/test/file_scan_task_reader_test.cc
@@ -36,11 +36,13 @@
 
 #include "iceberg/arrow/arrow_io_internal.h"
 #include "iceberg/arrow/arrow_register.h"
+#include "iceberg/arrow_c_data.h"
 #include "iceberg/arrow_c_data_guard_internal.h"
 #include "iceberg/arrow_c_data_util_internal.h"
 #include "iceberg/data/deletion_vector_writer.h"
 #include "iceberg/data/equality_delete_writer.h"
 #include "iceberg/data/position_delete_writer.h"
+#include "iceberg/deletes/position_delete_index.h"
 #include "iceberg/file_format.h"
 #include "iceberg/file_io.h"
 #include "iceberg/file_reader.h"
diff --git a/src/iceberg/test/position_delete_index_test.cc b/src/iceberg/test/position_delete_index_test.cc
@@ -25,7 +25,9 @@
 
 #include <gtest/gtest.h>
 
+#include "iceberg/file_format.h"
 #include "iceberg/manifest/manifest_entry.h"
+#include "iceberg/result.h"
 #include "iceberg/test/matchers.h"
 
 namespace iceberg {
diff --git a/src/iceberg/util/gzip_internal.cc b/src/iceberg/util/gzip_internal.cc
@@ -19,11 +19,15 @@
 
 #include "iceberg/util/gzip_internal.h"
 
+#include <zconf.h>
 #include <zlib.h>
 
 #include <cstring>
+#include <memory>
+#include <string>
 #include <vector>
 
+#include "iceberg/result.h"
 #include "iceberg/util/macros.h"
 
 namespace iceberg {
diff --git a/src/iceberg/util/string_util.cc b/src/iceberg/util/string_util.cc
@@ -22,7 +22,13 @@
 #include <utf8proc.h>
 
 #include <array>
+#include <cstddef>
+#include <cstdint>
+#include <string>
+#include <string_view>
+#include <vector>
 
+#include "iceberg/result.h"
 #include "iceberg/util/macros.h"
 
 namespace iceberg {
