Update Metadata creation to return unique_ptr

Author: All-less

src/iceberg/inspect/history_table.cc

@@ -48,8 +48,8 @@ TableIdentifier HistoryTable::CreateName(const TableIdentifier& source_name) {
   return TableIdentifier{source_name.ns, source_name.name + ".history"};
 }
 
-Result<std::shared_ptr<HistoryTable>> HistoryTable::Make(std::shared_ptr<Table> table) {
-  return std::shared_ptr<HistoryTable>(new HistoryTable(table));
+Result<std::unique_ptr<HistoryTable>> HistoryTable::Make(std::shared_ptr<Table> table) {
+  return std::unique_ptr<HistoryTable>(new HistoryTable(table));
 }
 
 }  // namespace iceberg

src/iceberg/inspect/history_table.h

@@ -42,7 +42,7 @@ class ICEBERG_EXPORT HistoryTable : public MetadataTable {
   ///
   /// \param[in] table The source table
   /// \return A HistoryTable instance or error status
-  static Result<std::shared_ptr<HistoryTable>> Make(std::shared_ptr<Table> table);
+  static Result<std::unique_ptr<HistoryTable>> Make(std::shared_ptr<Table> table);
 
   ~HistoryTable() override;
 

src/iceberg/inspect/metadata_table.cc

@@ -54,12 +54,12 @@ Result<std::unique_ptr<TableScanBuilder>> MetadataTable::NewScan() const {
   return NotSupported("TODO: Scanning metadata tables is not yet supported");
 };
 
-Result<std::shared_ptr<SnapshotsTable>> MetadataTableFactory::GetSnapshotsTable(
+Result<std::unique_ptr<SnapshotsTable>> MetadataTableFactory::GetSnapshotsTable(
     std::shared_ptr<Table> table) {
   return SnapshotsTable::Make(table);
 }
 
-Result<std::shared_ptr<HistoryTable>> MetadataTableFactory::GetHistoryTable(
+Result<std::unique_ptr<HistoryTable>> MetadataTableFactory::GetHistoryTable(
     std::shared_ptr<Table> table) {
   return HistoryTable::Make(table);
 }

src/iceberg/inspect/metadata_table.h

@@ -177,14 +177,14 @@ class ICEBERG_EXPORT MetadataTableFactory {
   ///
   /// \param table The source table
   /// \return A SnapshotsTable exposing all snapshots or error status
-  static Result<std::shared_ptr<SnapshotsTable>> GetSnapshotsTable(
+  static Result<std::unique_ptr<SnapshotsTable>> GetSnapshotsTable(
       std::shared_ptr<Table> table);
 
   /// \brief Create a HistoryTable from a table
   ///
   /// \param table The source table
   /// \return A HistoryTable exposing snapshot history or error status
-  static Result<std::shared_ptr<HistoryTable>> GetHistoryTable(
+  static Result<std::unique_ptr<HistoryTable>> GetHistoryTable(
       std::shared_ptr<Table> table);
 };
 

src/iceberg/inspect/snapshots_table.cc

@@ -54,9 +54,9 @@ TableIdentifier SnapshotsTable::CreateName(const TableIdentifier& source_name) {
   return TableIdentifier{source_name.ns, source_name.name + ".snapshots"};
 }
 
-Result<std::shared_ptr<SnapshotsTable>> SnapshotsTable::Make(
+Result<std::unique_ptr<SnapshotsTable>> SnapshotsTable::Make(
     std::shared_ptr<Table> table) {
-  return std::shared_ptr<SnapshotsTable>(new SnapshotsTable(table));
+  return std::unique_ptr<SnapshotsTable>(new SnapshotsTable(table));
 }
 
 }  // namespace iceberg

src/iceberg/inspect/snapshots_table.h

@@ -42,7 +42,7 @@ class ICEBERG_EXPORT SnapshotsTable : public MetadataTable {
   ///
   /// \param[in] table The source table
   /// \return A SnapshotsTable instance or error status
-  static Result<std::shared_ptr<SnapshotsTable>> Make(std::shared_ptr<Table> table);
+  static Result<std::unique_ptr<SnapshotsTable>> Make(std::shared_ptr<Table> table);
 
   ~SnapshotsTable() override;