[DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies?

[MisterRaindrop]

I encountered a problem when implementing the code. The NameMappingFromJson code in json_internal is dependent on iceberg-bundle, and iceberg also depends on it. This kind of dependency causes the tests to fail. Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies?

Here is my MR implementation. #127
Please let me know if there are any issues or if the implementation is incorrect. Also, if there is a better approach, please share it with me.

[wgtmac]

NameMappingFromJson shouldn't depend on iceberg-bundle. Could you double check if any dependency of avro or arrow caused the failure?

[MisterRaindrop]

I didn’t make it clear. I called NameMappingFromJson in avro_read for name mapping. However, this method is defined in json_internal, and if I reference it, it will cause problems.

[wgtmac]

Got it. Could you please try to add ICEBERG_EXPORT to the declaration of NameMappingFromJson function so it is exported in the libiceberg?

[MisterRaindrop]

Thanks I'll have it a try