fix: Correct BuildTable method signature#163
Merged
Fokko merged 4 commits intoapache:mainfrom Aug 8, 2025
Merged
Conversation
HeartLinked
force-pushed
the
fix_catalog
branch
from
2fa2e4d to
fa7bed9
Compare
wgtmac
approved these changes
Aug 6, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
+1
Left some nits.
BTW, this is actually a fix for the wrong signature of BuildTable. We need to reflect this in the PR title.
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
HeartLinked
changed the title
Co-authored-by: Gang Wu <ustcwg@gmail.com>
HeartLinked
force-pushed
the
fix_catalog
branch
from
5ad7a9a to
0f7bcad
Compare
Member
|
@Fokko @zeroshade Could you help review this? Thanks! |
Fokko
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the confusing inline class TableBuilder forward declaration from the BuildTable method.
Replaces it with a standard forward declaration at the namespace level for better clarity.