Merged
Conversation
wgtmac
approved these changes
Aug 20, 2025
zeroshade
approved these changes
Aug 22, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
just one question, but otherwise looks good to me
|
|
||
| return std::stoi(std::string(field_id_value.data, field_id_value.size_bytes)); | ||
| int32_t field_id = kUnknownFieldId; | ||
| std::from_chars(field_id_value.data, field_id_value.data + field_id_value.size_bytes, |
Member
There was a problem hiding this comment.
should this check the ec return also?
Collaborator
Author
There was a problem hiding this comment.
If ec is std::errc(), the field_id is still kUnknownFieldId, this check is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.