Skip to content

refactor: enhance forward declarations in type_fwd.h to reduce compile dependencies#187

Merged
Fokko merged 2 commits intoapache:mainfrom
HeartLinked:refector/type_fwd
Aug 25, 2025
Merged

refactor: enhance forward declarations in type_fwd.h to reduce compile dependencies#187
Fokko merged 2 commits intoapache:mainfrom
HeartLinked:refector/type_fwd

Conversation

@HeartLinked
Copy link
Copy Markdown
Contributor

Enhanced the forward declaration system in type_fwd.h to reduce compilation dependencies and improve build times.

Changes Made

  • Added missing forward declarations for commonly used classes
  • Reorganized declarations into logical groups with descriptive comments
  • Removed outdated TODO comment regarding (These classes were already properly declared):
    • StructLike
    • MetadataUpdate
    • UpdateRequirement
    • AppendFiles

@zhjwpku
Copy link
Copy Markdown
Collaborator

zhjwpku commented Aug 21, 2025

Enhanced the forward declaration system in type_fwd.h to reduce compilation dependencies and improve build times.

Changes Made

  • Added missing forward declarations for commonly used classes
  • Reorganized declarations into logical groups with descriptive comments
  • Removed outdated TODO comment regarding (These classes were already properly declared):

I don't think this is true, so I'd prefer to leave the TODO comment as is.

  • StructLike
  • MetadataUpdate
  • UpdateRequirement
  • AppendFiles

Other than that, the PR looks good.

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Aug 25, 2025

Thanks for working on this @HeartLinked, and thanks for the review @zhjwpku & @wgtmac 🙌

@Fokko Fokko merged commit 58d926f into apache:main Aug 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants