feat: implement basic parquet writer and add roundtrip tests#198
Merged
zeroshade merged 9 commits intoapache:mainfrom Sep 3, 2025
Merged
feat: implement basic parquet writer and add roundtrip tests#198zeroshade merged 9 commits intoapache:mainfrom
zeroshade merged 9 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a basic ParquetWriter class for writing ArrowArray data to Parquet files. The implementation follows the Writer interface pattern and uses Apache Arrow/Parquet libraries for the underlying functionality.
- Adds ParquetWriter class with PIMPL pattern for encapsulation
- Implements core writer operations: Open, Write, Close with Arrow/Parquet integration
- Provides placeholder implementations for metrics, length, and split_offsets methods
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/iceberg/parquet/parquet_writer.h | Header file defining the ParquetWriter class interface with PIMPL pattern |
| src/iceberg/parquet/parquet_writer.cc | Implementation of ParquetWriter with Arrow/Parquet integration and factory registration |
| src/iceberg/CMakeLists.txt | Adds parquet_writer.cc to the build configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
602b681 to
978dfcf
Compare
wgtmac
reviewed
Sep 1, 2025
3039e80 to
90039fb
Compare
1f9507a to
02a05cc
Compare
wgtmac
reviewed
Sep 2, 2025
wgtmac
approved these changes
Sep 3, 2025
zeroshade
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parquet writer factory and basic parquet writer without metrics.