Merged
Conversation
zhjwpku
force-pushed
the
add_rolling_manifest_writer
branch
from
a7bb821 to
24182ac
Compare
wgtmac
approved these changes
Dec 29, 2025
| /// \brief Add an added entry for a file. | ||
| /// | ||
| /// \param file a data file | ||
| /// \return Status::OK() if the entry was written successfully |
Member
There was a problem hiding this comment.
Unrelated to this PR: I think we don't have Status::OK() method. We may need to fix all these comments to not confuse readers.
Collaborator
Author
There was a problem hiding this comment.
Changed to \return Status indicating success or failure
| RollingManifestWriter::~RollingManifestWriter() { | ||
| // Ensure we close the current writer if not already closed | ||
| if (!closed_) { | ||
| (void)CloseCurrentWriter(); |
Member
There was a problem hiding this comment.
Suggested change
| (void)CloseCurrentWriter(); | |
| std::ignore = CloseCurrentWriter(); |
Member
There was a problem hiding this comment.
BTW, why not directly calling Close() so you don't need to check closed_?
Collaborator
Author
There was a problem hiding this comment.
Changed to Close()
| if (length_result.has_value()) { | ||
| return length_result.value() >= target_file_size_in_bytes_; | ||
| } | ||
| // If we can't get the length, don't roll |
Member
There was a problem hiding this comment.
Not sure if this is a good idea. What if it is a fatal error returned by the underlying writer?
Collaborator
Author
There was a problem hiding this comment.
I left this as a TODO, let's revisit this later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.