Skip to content

feat: extend table scan to support v2 deletes #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 5 commits into from
Jan 6, 2026
Merged

feat: extend table scan to support v2 deletes #489

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53f4b32
feat: extend table scan to support v2 deletes
wgtmac Jan 5, 2026
f2541ae
Update src/iceberg/table_scan.h
wgtmac Jan 6, 2026
7e5f060
Update src/iceberg/table_scan.cc
wgtmac Jan 6, 2026
5b7f140
address feedback
wgtmac Jan 6, 2026
0f9afd7
Update src/iceberg/table_scan.cc
wgtmac Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/demo_example.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "iceberg/arrow/arrow_file_io.h"
#include "iceberg/avro/avro_register.h"
#include "iceberg/catalog/memory/in_memory_catalog.h"
#include "iceberg/manifest/manifest_entry.h"
#include "iceberg/parquet/parquet_register.h"
#include "iceberg/table.h"
#include "iceberg/table_scan.h"
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/table.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ const std::shared_ptr<TableMetadata>& Table::metadata() const { return metadata_
const std::shared_ptr<Catalog>& Table::catalog() const { return catalog_; }

Result<std::unique_ptr<TableScanBuilder>> Table::NewScan() const {
return std::make_unique<TableScanBuilder>(metadata_, io_);
return TableScanBuilder::Make(metadata_, io_);
}

Result<std::shared_ptr<Transaction>> Table::NewTransaction() {
Expand Down
Loading
Loading