Skip to content

feat: add StructLikeSet #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 3 commits into from
Mar 28, 2026
Merged

feat: add StructLikeSet #598

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96321e6
feat: add StructLikeSet for deduplicating StructLike rows
wgtmac Mar 23, 2026
4627a74
fix windows export
wgtmac Mar 24, 2026
d11ac9d
address comments
wgtmac Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/iceberg/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ set(ICEBERG_SOURCES
util/property_util.cc
util/snapshot_util.cc
util/string_util.cc
util/struct_like_set.cc
util/temporal_util.cc
util/timepoint.cc
util/transform_util.cc
Expand Down
25 changes: 24 additions & 1 deletion src/iceberg/iceberg_export.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,31 @@
# else
# define ICEBERG_EXPORT __declspec(dllimport)
# endif
#else // Not Windows

# define ICEBERG_TEMPLATE_EXPORT ICEBERG_EXPORT

// For template class declarations. Empty on MSVC: dllexport on a class template
// declaration combined with extern template triggers C4910.
# if defined(_MSC_VER)
# define ICEBERG_TEMPLATE_CLASS_EXPORT
# else
# define ICEBERG_TEMPLATE_CLASS_EXPORT ICEBERG_EXPORT
# endif

// For extern template declarations. Empty when building the DLL on MSVC:
// `extern` + `dllexport` is contradictory and triggers C4910.
# if defined(_MSC_VER) && defined(ICEBERG_EXPORTING) && !defined(ICEBERG_STATIC)
# define ICEBERG_EXTERN_TEMPLATE_CLASS_EXPORT
# else
# define ICEBERG_EXTERN_TEMPLATE_CLASS_EXPORT ICEBERG_TEMPLATE_EXPORT
# endif

#else // Non-Windows
# ifndef ICEBERG_EXPORT
# define ICEBERG_EXPORT __attribute__((visibility("default")))
# endif

# define ICEBERG_TEMPLATE_EXPORT
# define ICEBERG_TEMPLATE_CLASS_EXPORT ICEBERG_EXPORT
# define ICEBERG_EXTERN_TEMPLATE_CLASS_EXPORT ICEBERG_TEMPLATE_EXPORT
#endif
1 change: 1 addition & 0 deletions src/iceberg/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ iceberg_sources = files(
'util/property_util.cc',
'util/snapshot_util.cc',
'util/string_util.cc',
'util/struct_like_set.cc',
'util/temporal_util.cc',
'util/timepoint.cc',
'util/transform_util.cc',
Expand Down
1 change: 1 addition & 0 deletions src/iceberg/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ add_iceberg_test(util_test
formatter_test.cc
location_util_test.cc
string_util_test.cc
struct_like_set_test.cc
transform_util_test.cc
truncate_util_test.cc
url_encoder_test.cc
Expand Down
1 change: 1 addition & 0 deletions src/iceberg/test/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ iceberg_tests = {
'formatter_test.cc',
'location_util_test.cc',
'string_util_test.cc',
'struct_like_set_test.cc',
'transform_util_test.cc',
'truncate_util_test.cc',
'url_encoder_test.cc',
Expand Down
Loading
Loading