Skip to content

feat(inspect): Add base class for metadata table support#607

Open
All-less wants to merge 10 commits into
apache:mainfrom
All-less:metadata-table
Open

feat(inspect): Add base class for metadata table support#607
All-less wants to merge 10 commits into
apache:mainfrom
All-less:metadata-table

Conversation

@All-less

Copy link
Copy Markdown

This PR kicks off the implementation of table inspection support.

  • Add BaseMetadataTable class (without scan support for now).
  • Add MetadataTableFactory as an entry point for creating metadata tables.
  • Add SnapshotsTable and HistoryTable as example impl.

@All-less All-less marked this pull request as draft March 29, 2026 20:52

@wgtmac wgtmac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I've left some preliminary comments.

Comment thread src/iceberg/inspect/metadata_table.h Outdated
Comment thread src/iceberg/inspect/metadata_table.h Outdated
Comment thread src/iceberg/inspect/metadata_table.h Outdated
Comment thread src/iceberg/inspect/metadata_table.cc Outdated
Comment thread src/iceberg/CMakeLists.txt Outdated
Comment thread src/iceberg/inspect/snapshots_table.h
Comment thread src/iceberg/CMakeLists.txt
Comment thread src/iceberg/inspect/metadata_table_factory.h Outdated
Comment thread src/iceberg/inspect/metadata_table_factory.h Outdated
Comment thread src/iceberg/inspect/metadata_table_factory.h Outdated
Comment thread src/iceberg/type_fwd.h
Comment thread src/iceberg/inspect/metadata_table.h Outdated
Comment thread src/iceberg/inspect/metadata_table.h Outdated
Comment thread src/iceberg/inspect/metadata_table.h Outdated
Comment thread src/iceberg/inspect/metadata_table.h Outdated
@wgtmac

wgtmac commented May 21, 2026

Copy link
Copy Markdown
Member

Please rebase to resolve conflicts. Let me know when it is ready to review again.

@wgtmac wgtmac added the awaiting author action Author needs to address comments, resolve conflicts, answer questions, etc. label May 28, 2026
@wgtmac wgtmac marked this pull request as ready for review June 5, 2026 09:58
@wgtmac

wgtmac commented Jun 5, 2026

Copy link
Copy Markdown
Member

Could you please make ci happy (and possibly rebase on the latest main branch)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting author action Author needs to address comments, resolve conflicts, answer questions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants