fix(parquet): check compression codec availability#656
Open
wgtmac wants to merge 2 commits into
Open
Conversation
WZhuo
approved these changes
May 19, 2026
| } else { | ||
| return InvalidArgument("Unsupported Parquet compression codec: {}", compression_name); | ||
| } | ||
| return compression; |
Collaborator
There was a problem hiding this comment.
It's reachable. The returns were changed to assignments except the final else branch. But I have no idea if that's a better style :-)
raulcd
reviewed
May 19, 2026
| ::arrow::Compression::type compression; | ||
| }; | ||
|
|
||
| std::optional<ParquetCodec> UnavailableParquetCodec() { |
Member
There was a problem hiding this comment.
LGTM should this function return the list of unavailable codecs instead of the first one? Otherwise I feel like the name could be slightly misleading, maybe FirstUnavailableParquetCodec.
raulcd
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidArgumentwhen a requested Parquet codec is not built into Arrow.Test Plan
cmake --build build --target parquet_test data_test && ctest --test-dir build -R 'parquet_test|data_test' --output-on-failuregit diff --check