pass anon explicitly to s3fs.S3FileSystem

Author: gweaverbiodev

pyiceberg/io/fsspec.py

@@ -168,9 +168,11 @@ def _s3(properties: Properties) -> AbstractFileSystem:
         config_kwargs["read_timeout"] = float(request_timeout)
 
     if s3_anonymous := properties.get(S3_ANONYMOUS):
-        config_kwargs["anon"] = strtobool(s3_anonymous)
+        anon = strtobool(s3_anonymous)
+    else:
+        anon = False
 
-    fs = S3FileSystem(client_kwargs=client_kwargs, config_kwargs=config_kwargs)
+    fs = S3FileSystem(anon=anon, client_kwargs=client_kwargs, config_kwargs=config_kwargs)
 
     for event_name, event_function in register_events.items():
         fs.s3.meta.events.unregister(event_name, unique_id=1925)

tests/io/test_fsspec.py

@@ -284,16 +284,15 @@ def test_fsspec_s3_session_properties_with_anonymous() -> None:
         s3_fileio.new_input(location=f"s3://warehouse/{filename}")
 
         mock_s3fs.assert_called_with(
+            anon=True,
             client_kwargs={
                 "endpoint_url": "http://localhost:9000",
                 "aws_access_key_id": "admin",
                 "aws_secret_access_key": "password",
                 "region_name": "us-east-1",
                 "aws_session_token": "s3.session-token",
             },
-            config_kwargs={
-                "anon": True,
-            },
+            config_kwargs={},
         )