Strip format-version from persisted properties on replace

Match new_table_metadata's behavior of popping format-version before
persistence, and validate schema compatibility against the resolved
format version at the same site.

Author: smaheshwar-pltr

pyiceberg/catalog/__init__.py

@@ -549,6 +549,7 @@ def _replace_staged_table(
             int(requested_format_version) if requested_format_version is not None else existing_metadata.format_version
         )
         iceberg_schema = self._convert_schema_if_needed(schema, cast(TableVersion, resolved_format_version))
+        iceberg_schema.check_format_version_compatibility(cast(TableVersion, resolved_format_version))
 
         fresh_schema, _ = assign_fresh_schema_ids_for_replace(
             iceberg_schema, existing_metadata.schema(), existing_metadata.last_column_id

pyiceberg/table/__init__.py

@@ -1102,8 +1102,10 @@ def _initial_changes(
             self._updates += (SetLocationUpdate(location=new_location),)
 
         # Merge properties (SetPropertiesUpdate merges onto existing properties).
-        if new_properties:
-            self._updates += (SetPropertiesUpdate(updates=new_properties),)
+        # Strip `format-version` so it does not get persisted as a regular property.
+        persisted_properties = {k: v for k, v in new_properties.items() if k != TableProperties.FORMAT_VERSION}
+        if persisted_properties:
+            self._updates += (SetPropertiesUpdate(updates=persisted_properties),)
 
     @staticmethod
     def _find_matching_schema_id(table_metadata: TableMetadata, schema: Schema) -> int | None: