Inline _replace_staged_table into Catalog.replace_table_transaction

After the previous commit collapsed both per-catalog overrides onto
Catalog, _replace_staged_table was called from exactly one place and
its only role was to hand back a five-element tuple to be re-spread
into a constructor call. Removing the helper removes the tuple and
the indirection.

Author: smaheshwar-pltr

pyiceberg/catalog/__init__.py

@@ -480,38 +480,6 @@ def replace_table_transaction(
         Raises:
             NoSuchTableError: If the table does not exist.
         """
-        staged_table, fresh_schema, fresh_spec, fresh_sort_order, resolved_location = self._replace_staged_table(
-            identifier, schema, location, partition_spec, sort_order, properties
-        )
-        return ReplaceTableTransaction(
-            table=staged_table,
-            new_schema=fresh_schema,
-            new_spec=fresh_spec,
-            new_sort_order=fresh_sort_order,
-            new_location=resolved_location,
-            new_properties=properties,
-        )
-
-    def _replace_staged_table(
-        self,
-        identifier: str | Identifier,
-        schema: Schema | pa.Schema,
-        location: str | None,
-        partition_spec: PartitionSpec,
-        sort_order: SortOrder,
-        properties: Properties,
-    ) -> tuple[StagedTable, Schema, PartitionSpec, SortOrder, str]:
-        """Load the existing table and build fresh schema/spec/sort-order for replacement.
-
-        - reuses existing field IDs by name (from the current schema)
-        - reuses partition field IDs by `(source, transform)` across all specs (v2+),
-          or carries forward the current spec with `VoidTransform`s (v1)
-        - reassigns sort field IDs against the fresh schema
-        - resolves `location` to the existing table's location when omitted
-
-        Returns:
-            A tuple `(staged_table, fresh_schema, fresh_partition_spec, fresh_sort_order, resolved_location)`.
-        """
         existing_table = self.load_table(identifier)
         existing_metadata = existing_table.metadata
 
@@ -534,7 +502,6 @@ def _replace_staged_table(
         fresh_schema, _ = assign_fresh_schema_ids_for_replace(
             iceberg_schema, existing_metadata.schema(), existing_metadata.last_column_id
         )
-
         fresh_partition_spec, _ = assign_fresh_partition_spec_ids_for_replace(
             partition_spec,
             iceberg_schema,
@@ -544,7 +511,6 @@ def _replace_staged_table(
             format_version=existing_metadata.format_version,
             current_spec=existing_metadata.spec(),
         )
-
         fresh_sort_order = assign_fresh_sort_order_ids(sort_order, iceberg_schema, fresh_schema)
 
         resolved_location = location.rstrip("/") if location else existing_metadata.location
@@ -558,7 +524,14 @@ def _replace_staged_table(
             io=existing_table.io,
             catalog=self,
         )
-        return staged_table, fresh_schema, fresh_partition_spec, fresh_sort_order, resolved_location
+        return ReplaceTableTransaction(
+            table=staged_table,
+            new_schema=fresh_schema,
+            new_spec=fresh_partition_spec,
+            new_sort_order=fresh_sort_order,
+            new_location=resolved_location,
+            new_properties=properties,
+        )
 
     @abstractmethod
     def load_table(self, identifier: str | Identifier) -> Table: