address comments

Author: rambleraptor

pyiceberg/catalog/__init__.py

@@ -930,6 +930,16 @@ def purge_table(self, identifier: str | Identifier) -> None:
         delete_files(io, prev_metadata_files, PREVIOUS_METADATA)
         delete_files(io, {table.metadata_location}, METADATA)
 
+    def create_view(
+        self,
+        identifier: str | Identifier,
+        schema: Schema | pa.Schema,
+        view_version: ViewVersion,
+        location: str | None = None,
+        properties: Properties = EMPTY_DICT,
+    ) -> View:
+        raise NotImplementedError
+
     def _create_staged_table(
         self,
         identifier: str | Identifier,

pyiceberg/catalog/bigquery_metastore.py

@@ -41,8 +41,6 @@
 from pyiceberg.table.update import TableRequirement, TableUpdate
 from pyiceberg.typedef import EMPTY_DICT, Identifier, Properties
 from pyiceberg.utils.config import Config
-from pyiceberg.view import View
-from pyiceberg.view.metadata import ViewVersion
 
 if TYPE_CHECKING:
     import pyarrow as pa
@@ -303,16 +301,6 @@ def register_table(self, identifier: str | Identifier, metadata_location: str) -
 
         return self.load_table(identifier=identifier)
 
-    def create_view(
-        self,
-        identifier: str | Identifier,
-        schema: Schema | pa.Schema,
-        view_version: ViewVersion,
-        location: str | None = None,
-        properties: Properties = EMPTY_DICT,
-    ) -> View:
-        raise NotImplementedError
-
     def list_views(self, namespace: str | Identifier) -> list[Identifier]:
         raise NotImplementedError
 

pyiceberg/view/metadata.py

@@ -86,7 +86,7 @@ class ViewMetadata(IcebergBaseModel):
     """A list of known versions of the view"""
     version_log: list[ViewHistoryEntry] = Field(alias="version-log")
     """A list of version log entries"""
-    properties: Properties = Field(default_factory=dict)
+    properties: dict[str, str] = Field(default_factory=dict)
     """A string to string map of view properties"""
 
     @field_validator("properties", mode="before")