Skip to content

Commit 24e0033

Browse files
committed
let uv handle venv
1 parent a854129 commit 24e0033

File tree

1 file changed

+8
-25
lines changed

1 file changed

+8
-25
lines changed

Makefile

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -66,21 +66,10 @@ install-uv: ## Ensure uv is installed
6666
echo "uv is already installed."; \
6767
fi
6868

69-
setup-venv: ## Create virtual environment (if not exists)
70-
@if [ ! -d ".venv" ]; then \
71-
uv venv $(PYTHON_ARG); \
72-
else \
73-
echo "Virtual environment already exists at .venv"; \
74-
fi
75-
76-
install-dependencies: setup-venv ## Install all dependencies including extras
69+
install: install-uv ## Install uv, dependencies, and pre-commit hooks
7770
uv sync $(PYTHON_ARG) --all-extras
78-
79-
install-hooks: ## Install pre-commit hooks
8071
uv run $(PYTHON_ARG) prek install
8172

82-
install: install-uv install-dependencies install-hooks ## Install uv, dependencies, and pre-commit hooks
83-
8473
# ===============
8574
# Code Validation
8675
# ===============
@@ -104,7 +93,7 @@ test: ## Run all unit tests (excluding integration)
10493

10594
test-integration: test-integration-setup test-integration-exec test-integration-cleanup ## Run integration tests
10695

107-
test-integration-setup: install ## Start Docker services for integration tests
96+
test-integration-setup: ## Start Docker services for integration tests
10897
docker compose -f dev/docker-compose-integration.yml kill
10998
docker compose -f dev/docker-compose-integration.yml rm -f
11099
docker compose -f dev/docker-compose-integration.yml up -d --build --wait
@@ -151,29 +140,23 @@ coverage-report: ## Combine and report coverage
151140

152141
##@ Documentation
153142

154-
docs-install: ## Install docs dependencies (included in default groups)
155-
uv sync $(PYTHON_ARG) --group docs
156-
157143
docs-serve: ## Serve local docs preview (hot reload)
158-
uv run $(PYTHON_ARG) mkdocs serve -f mkdocs/mkdocs.yml --livereload
144+
uv run $(PYTHON_ARG) --group docs mkdocs serve -f mkdocs/mkdocs.yml --livereload
159145

160146
docs-build: ## Build the static documentation site
161-
uv run $(PYTHON_ARG) mkdocs build -f mkdocs/mkdocs.yml --strict
147+
uv run $(PYTHON_ARG) --group docs mkdocs build -f mkdocs/mkdocs.yml --strict
162148

163149
# ========================
164150
# Experimentation
165151
# ========================
166152

167153
##@ Experimentation
168154

169-
notebook-install: ## Install notebook dependencies
170-
uv sync $(PYTHON_ARG) --all-extras --group notebook
171-
172-
notebook: notebook-install ## Launch notebook for experimentation
173-
uv run jupyter lab --notebook-dir=notebooks
155+
notebook: ## Launch notebook for experimentation
156+
uv run $(PYTHON_ARG) --all-extras --group notebook jupyter lab --notebook-dir=notebooks
174157

175-
notebook-infra: notebook-install test-integration-setup ## Launch notebook with integration test infra (Spark, Iceberg Rest Catalog, object storage, etc.)
176-
uv run jupyter lab --notebook-dir=notebooks
158+
notebook-infra: test-integration-setup ## Launch notebook with integration test infra (Spark, Iceberg Rest Catalog, object storage, etc.)
159+
uv run $(PYTHON_ARG) --all-extras --group notebook jupyter lab --notebook-dir=notebooks
177160

178161
# ===================
179162
# Project Maintenance

0 commit comments

Comments
 (0)