Apply suggestions from code review

Author: kevinjqliu

pyiceberg/catalog/rest/__init__.py

@@ -237,7 +237,7 @@ class IdentifierKind(Enum):
 SIGV4_REGION = "rest.signing-region"
 SIGV4_SERVICE = "rest.signing-name"
 SIGV4_MAX_RETRIES = "rest.sigv4.max-retries"
-SIGV4_DEFAULT_MAX_RETRIES = 10
+SIGV4_MAX_RETRIES_DEFAULT = 10
 EMPTY_BODY_SHA256: str = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
 OAUTH2_SERVER_URI = "oauth2-server-uri"
 SNAPSHOT_LOADING_MODE = "snapshot-loading-mode"
@@ -699,7 +699,7 @@ def _init_sigv4(self, session: Session) -> None:
         class SigV4Adapter(HTTPAdapter):
             def __init__(self, **properties: str):
                 self._properties = properties
-                max_retries = property_as_int(self._properties, SIGV4_MAX_RETRIES, SIGV4_DEFAULT_MAX_RETRIES)
+                max_retries = property_as_int(self._properties, SIGV4_MAX_RETRIES, SIGV4_MAX_RETRIES_DEFAULT)
                 super().__init__(max_retries=max_retries)
                 self._boto_session = boto3.Session(
                     profile_name=get_first_property_value(self._properties, AWS_PROFILE_NAME),

tests/catalog/test_rest.py

@@ -33,7 +33,7 @@
     DEFAULT_ENDPOINTS,
     EMPTY_BODY_SHA256,
     OAUTH2_SERVER_URI,
-    SIGV4_DEFAULT_MAX_RETRIES,
+    SIGV4_MAX_RETRIES_DEFAULT,
     SIGV4_MAX_RETRIES,
     SNAPSHOT_LOADING_MODE,
     Capability,
@@ -546,7 +546,7 @@ def test_sigv4_adapter_default_retry_config(rest_mock: Mocker) -> None:
 
     adapter = catalog._session.adapters[catalog.uri]
     assert isinstance(adapter, HTTPAdapter)
-    assert adapter.max_retries.total == SIGV4_DEFAULT_MAX_RETRIES
+    assert adapter.max_retries.total == SIGV4_MAX_RETRIES_DEFAULT
 
 
 def test_sigv4_adapter_override_retry_config(rest_mock: Mocker) -> None: