Commit 36ed4af
authored
add X-Client-Version header to rest client (#2910)
Closes #2373
# Rationale for this change
Bringing parity to the headers in Python.
The version is as per the [HttpClient in
Java](https://github.com/apache/iceberg/blob/68e555b94f4706a2af41dcb561c84007230c0bc1/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java#L533-L534)
and the version string is matching
[IcebergBuild](https://github.com/apache/iceberg/blob/779af12312fcf70c1e6e52d610d64cf947fd0a4f/api/src/main/java/org/apache/iceberg/IcebergBuild.java#L67)
but with `PyIceberg` instead of Iceberg.
Previously, this was worked on #2652 but since that has stalled, adding
a fix to close our the issue. Thanks to @jaimeferj for his original PR.
## Are these changes tested?
- Added a test in `tests/catalog/test_rest.py` -
`test_client_version_header`
## Are there any user-facing changes?
No1 parent b3a8027 commit 36ed4af
2 files changed
+7
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
617 | 617 | | |
618 | 618 | | |
619 | 619 | | |
| 620 | + | |
620 | 621 | | |
621 | 622 | | |
622 | 623 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1944 | 1944 | | |
1945 | 1945 | | |
1946 | 1946 | | |
| 1947 | + | |
| 1948 | + | |
| 1949 | + | |
| 1950 | + | |
| 1951 | + | |
| 1952 | + | |
1947 | 1953 | | |
1948 | 1954 | | |
1949 | 1955 | | |
| |||
0 commit comments