Skip to content

Commit 39e08a1

Browse files
authored
ci: fix nightly and release (#3215)
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Follow up to #3193 env vars does not play nice with windows os (because the default shell is powershell). We need to set to bash so that env vars are interpreted correctly ## Are these changes tested? Yes Ran on fork nightly: https://github.com/kevinjqliu/iceberg-python/actions/runs/23805622644 release: https://github.com/kevinjqliu/iceberg-python/actions/runs/23805619712 ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent f4d475e commit 39e08a1

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

.github/workflows/nightly-pypi-build.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ permissions:
2929

3030
jobs:
3131
set-version:
32-
if: github.repository == 'apache/iceberg-python' # Only run for apache repo
32+
if: github.repository == 'apache/iceberg-python' || github.event_name == 'workflow_dispatch' # Run on schedule for apache repo, or on manual dispatch from any repo
3333
runs-on: ubuntu-latest
3434
outputs:
3535
VERSION: ${{ steps.set-version.outputs.VERSION }}
@@ -55,6 +55,7 @@ jobs:
5555
5656
- name: Debug version
5757
run: echo "Publishing version ${STEPS_SET_VERSION_OUTPUTS_VERSION}"
58+
shell: bash
5859
env:
5960
STEPS_SET_VERSION_OUTPUTS_VERSION: ${{ steps.set-version.outputs.VERSION }}
6061

@@ -65,6 +66,7 @@ jobs:
6566
version: ${{ needs.set-version.outputs.VERSION }}
6667
testpypi-publish:
6768
name: Publish to TestPypi
69+
if: github.repository == 'apache/iceberg-python' # Only run for apache repo
6870
needs:
6971
- nightly-build
7072
runs-on: ubuntu-latest

.github/workflows/pypi-build-artifacts.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ jobs:
5656
uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 # v7.3.1
5757

5858
- name: Set version with RC
59+
shell: bash
5960
env:
6061
VERSION: ${{ inputs.VERSION }}
6162
run: uv version "$VERSION"

.github/workflows/python-release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ jobs:
8181
# Export variables for future steps
8282
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
8383
echo "RC=$RC" >> $GITHUB_OUTPUT
84+
shell: bash
8485
env:
8586
GITHUB_EVENT_INPUTS_VERSION: ${{ github.event.inputs.version }}
8687
GITHUB_EVENT_INPUTS_RC: ${{ github.event.inputs.rc }}
@@ -89,6 +90,7 @@ jobs:
8990
run: |
9091
echo "Using Version: ${STEPS_VALIDATE_INPUTS_OUTPUTS_VERSION}"
9192
echo "Using RC: ${STEPS_VALIDATE_INPUTS_OUTPUTS_RC}"
93+
shell: bash
9294
env:
9395
STEPS_VALIDATE_INPUTS_OUTPUTS_VERSION: ${{ steps.validate-inputs.outputs.VERSION }}
9496
STEPS_VALIDATE_INPUTS_OUTPUTS_RC: ${{ steps.validate-inputs.outputs.RC }}
@@ -113,6 +115,7 @@ jobs:
113115
enable-cache: false
114116

115117
- name: Validate current pyiceberg version
118+
shell: bash
116119
env:
117120
VERSION: ${{ needs.validate-inputs.outputs.VERSION }}
118121
run: |

0 commit comments

Comments
 (0)