Commit 4cad1c3
Fix: make test-coverage to properly enable coverage for all test suites (#2989)
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
The `test-coverage` target was failing with "No data to combine" because
the `COVERAGE=1` variable wasn't being propagated to prerequisite test
targets.
Make's target-specific variable syntax (`test-coverage: COVERAGE=1`)
only sets the variable for that specific target, not for its
prerequisites when they execute as separate Make invocations.
Found this out when verifying release, which is the only place we run
`make test-coverage`. CI runs `make coverage-report`
## Are these changes tested?
Ran `make test-coverage` before and after
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->1 parent a2c1b7f commit 4cad1c3
1 file changed
+3
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
137 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
138 | 139 | | |
139 | 140 | | |
140 | 141 | | |
| |||
0 commit comments