Skip to content

Commit 579f6c0

Browse files
authored
Apply suggestions from code review
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
1 parent a90cd7c commit 579f6c0

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

pyiceberg/catalog/rest/__init__.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1183,18 +1183,18 @@ def drop_namespace(self, namespace: str | Identifier) -> None:
11831183
def list_namespaces(self, namespace: str | Identifier = ()) -> list[Identifier]:
11841184
self._check_endpoint(Capability.V1_LIST_NAMESPACES)
11851185
namespace_tuple = self.identifier_to_tuple(namespace)
1186-
url = (
1187-
f"{Endpoints.list_namespaces}?parent={self._encode_namespace_path(namespace_tuple)}"
1188-
if namespace_tuple
1189-
else Endpoints.list_namespaces
1190-
)
11911186

11921187
namespaces: list[Identifier] = []
11931188
page_token: str | None = None
11941189

11951190
while True:
1196-
params = {"pageToken": page_token} if page_token else None
1197-
response = self._session.get(self.url(url), params=params)
1191+
params: dict[str, str] = {}
1192+
if namespace_tuple:
1193+
params["parent"] = self._encode_namespace_path(namespace_tuple)
1194+
if page_token:
1195+
params["pageToken"] = page_token
1196+
response = self._session.get(self.url(Endpoints.list_namespaces), params=params)
1197+
11981198
try:
11991199
response.raise_for_status()
12001200
except HTTPError as exc:

0 commit comments

Comments
 (0)