fix: cast TableMetadata to TableMetadataCommonFields in tests for mypy lint compliance

Author: Gayathri Srividya Rajavarapu

tests/table/test_init.py

@@ -824,6 +824,12 @@ def test_update_metadata_add_snapshot(table_v2: Table) -> None:
     )
 
     new_metadata = update_table_metadata(table_v2.metadata, (AddSnapshotUpdate(snapshot=new_snapshot),))
+    # Cast to TableMetadataCommonFields to satisfy mypy
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.snapshots) == 3
     assert new_metadata.snapshots[-1] == new_snapshot
     assert new_metadata.last_sequence_number == new_snapshot.sequence_number
@@ -841,6 +847,11 @@ def test_update_metadata_set_ref_snapshot(table_v2: Table) -> None:
     )
 
     new_metadata = update_table_metadata(table_v2.metadata, update)
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.snapshot_log) == 3
     assert new_metadata.snapshot_log[2].snapshot_id == 3051729675574597004
     assert new_metadata.current_snapshot_id == 3051729675574597004
@@ -865,6 +876,11 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table) -> None:
     )
 
     new_metadata = update_table_metadata(table_v2.metadata, (update,))
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.snapshot_log) == 3
     assert new_metadata.snapshot_log[2].snapshot_id == 3051729675574597004
     assert new_metadata.current_snapshot_id == 3051729675574597004
@@ -887,6 +903,11 @@ def test_update_remove_snapshots(table_v2: Table) -> None:
     assert len(table_v2.metadata.refs) == 2
     update = RemoveSnapshotsUpdate(snapshot_ids=[REMOVE_SNAPSHOT])
     new_metadata = update_table_metadata(table_v2.metadata, (update,))
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.snapshots) == 1
     assert new_metadata.snapshots[0].snapshot_id == KEEP_SNAPSHOT
     assert new_metadata.snapshots[0].parent_snapshot_id is None
@@ -909,6 +930,11 @@ def test_update_remove_snapshots_doesnt_exist(table_v2: Table) -> None:
 def test_update_remove_snapshots_remove_current_snapshot_id(table_v2: Table) -> None:
     update = RemoveSnapshotsUpdate(snapshot_ids=[3055729675574597004])
     new_metadata = update_table_metadata(table_v2.metadata, (update,))
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.refs) == 1
     assert new_metadata.refs["test"].snapshot_id == 3051729675574597004
     assert new_metadata.current_snapshot_id is None
@@ -919,6 +945,11 @@ def test_update_remove_snapshot_ref(table_v2: Table) -> None:
     assert len(table_v2.metadata.refs) == 2
     update = RemoveSnapshotRefUpdate(ref_name="test")
     new_metadata = update_table_metadata(table_v2.metadata, (update,))
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.refs) == 1
     assert new_metadata.refs["main"].snapshot_id == 3055729675574597004
 
@@ -929,6 +960,11 @@ def test_update_metadata_add_update_sort_order(table_v2: Table) -> None:
         table_v2.metadata,
         (AddSortOrderUpdate(sort_order=new_sort_order), SetDefaultSortOrderUpdate(sort_order_id=-1)),
     )
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
     assert len(new_metadata.sort_orders) == 2
     assert new_metadata.sort_orders[-1] == new_sort_order
     assert new_metadata.default_sort_order_id == new_sort_order.order_id
@@ -984,6 +1020,11 @@ def test_update_metadata_with_multiple_updates(table_v1: Table) -> None:
     new_metadata = update_table_metadata(base_metadata, test_updates)
     # rebuild the metadata to trigger validation
     new_metadata = TableMetadataUtil.parse_obj(copy(new_metadata.model_dump()))
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    new_metadata = cast(TableMetadataCommonFields, new_metadata)
 
     # UpgradeFormatVersionUpdate
     assert new_metadata.format_version == 2

tests/table/test_metadata.py

@@ -86,7 +86,11 @@ def test_from_byte_stream(example_table_metadata_v2: dict[str, Any]) -> None:
 
 def test_v2_metadata_parsing(example_table_metadata_v2: dict[str, Any]) -> None:
     """Test retrieving values from a TableMetadata instance of version 2"""
-    table_metadata = TableMetadataUtil.parse_obj(example_table_metadata_v2)
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    table_metadata = cast(TableMetadataCommonFields, TableMetadataUtil.parse_obj(example_table_metadata_v2))
 
     assert table_metadata.format_version == 2
     assert table_metadata.table_uuid == UUID("9c12d441-03fe-4693-9a96-a0705ddf69c1")

tests/table/test_sorting.py

@@ -77,7 +77,11 @@ def test_deserialize_sort_order(sort_order: SortOrder) -> None:
 
 
 def test_sorting_schema(example_table_metadata_v2: dict[str, Any]) -> None:
-    table_metadata = TableMetadataUtil.parse_raw(json.dumps(example_table_metadata_v2))
+    from typing import cast
+
+    from pyiceberg.table.metadata import TableMetadataCommonFields
+
+    table_metadata = cast(TableMetadataCommonFields, TableMetadataUtil.parse_raw(json.dumps(example_table_metadata_v2)))
 
     assert table_metadata.sort_orders == [
         SortOrder(